Closed Bug 823088 Opened 7 years ago Closed 7 years ago

Add a static assertion that bindings with descriptor.nativeOwnership == 'nsisupports' inherit from nsISupports

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
I noticed that we'd happily build when you make a class not inherit from nsISupports without updating the nativeOwnership. This adds static assertions in the code that reinterpret_casts to nsISupports*.
Attachment #693912 - Flags: review?(peterv)
Comment on attachment 693912 [details] [diff] [review]
Patch v1

r=me
Attachment #693912 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/bf26f61a0748
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.