823108 - Plugin elements without size specification have size 0x0

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Plug-ins, defect)

Description

[Georg Fritzsche [:gfritzsche]]

Attachment: test case

On trunk plugins without a size-specification are 0x0 unless they get a plugin-problem overlay/styling, in which they get the previously default size (240x200).

Comment 1

[Georg Fritzsche [:gfritzsche]]

Also, as mentioned over on bug 810082, we're missing test-coverage for this.

Comment 2

[Dana Keeler (she/her) [:keeler]]

Why is this desirable? I'd advocate for going the other way - plugins without a size specification are 0x0 even if given an overlay.

Comment 3

[Georg Fritzsche [:gfritzsche]]

Is there any upside to having them 0x0 sized and breaking with what we did before?
I only see chances of regressing page layouts and it breaks with what other browsers do (showing them non-0x0-sized).

Comment 4

[John Schoenick [:johns]]

How long has this been broken on our end?

I'm seeing that objects/embeds have a default 0x0 size, but then when flash loads in an embed tag it suddenly gets a default size from somewhere.

Comment 5

[Benjamin Smedberg]

Attachment: Testing HTML in a bunch of cases

Here's a test file that I wrote, and some results:

empty <object>

FF 16: 0-width
Nightly: 0-width
IE: 0-width
Chrome: sized

empty <embed>

FF 16: 0-width
Nightly: 0-width
IE: broken-plugin dot?
Chrome: sized

Flash-type <object> with no data:

FF16: display:none
Nightly: display:none
IE: sized
chrome: sized

Flash-type <embed> with no data:

FF16: sized
Nightly: sized
IE: sized
chrome: sized

<object data="cross-origin.swf">

FF16: display:none (!)
Nightly: display: none (!)
IE: sized
chrome: sized

<embed src="cross-origin.swf">

FF16: sized
Nightly: sized
IE: sized
chrome: sized

<object data="cross-origin.swf" type="application/x-shockwave-flash">

FF16: display:none (!)
Nightly: display:none (!)
IE: sized
chrome: sized

<embed src="cross-origin.swf" type="application/x-shockwave-flash">

FF16: display:none (!)
Nightly: display:none (!)
IE: sized
chrome: sized

Comment 6

[John Schoenick [:johns]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #5)
> <object data="cross-origin.swf" type="application/x-shockwave-flash">
> 
> FF16: display:none (!)
> Nightly: display:none (!)
> 
> <embed src="cross-origin.swf" type="application/x-shockwave-flash">
> 
> FF16: display:none (!)
> Nightly: display:none (!)

I'm not seeing this in the test case provided, the channel is taking a long time to load - but once it finishes it displays

Comment 7

[Georg Fritzsche [:gfritzsche]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #5)
> Here's a test file that I wrote, and some results:

Thanks for checking, looks like i jumped to the wrong conclusions here :/

On OSX with the current Nightly i have the same results, except:
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #5)
> <embed src="cross-origin.swf" type="application/x-shockwave-flash">
> 
> FF16: display:none (!)
> Nightly: display:none (!)
> IE: sized
> chrome: sized

That one is visible for me.

(In reply to John Schoenick [:johns] from comment #6)
> (In reply to Benjamin Smedberg  [:bsmedberg] from comment #5)
> > <object data="cross-origin.swf" type="application/x-shockwave-flash">
> > 
> > FF16: display:none (!)
> > Nightly: display:none (!)
> > 
> > <embed src="cross-origin.swf" type="application/x-shockwave-flash">
> > 
> > FF16: display:none (!)
> > Nightly: display:none (!)
> 
> I'm not seeing this in the test case provided, the channel is taking a long
> time to load - but once it finishes it displays

Do you mean only the embed, or does the object tag in that section actually work for you / show up?

Comment 8

[John Schoenick [:johns]]

(In reply to Georg Fritzsche [:gfritzsche] [away Dec 24 - Jan 1] from comment #7)
> Do you mean only the embed, or does the object tag in that section actually
> work for you / show up?

The last four tags on that page all load and play for me on nightly. Prior to the tags loading, they are display:none, but get a width/height after instantiating (perhaps because they are not tied to object frames while still loading?)

The last two object tags fail on FF17 :-/

Note that coolmathgames.com also takes a long time to respond even on nightly, the animations don't start playing for 30+ seconds

bug 767633 may have improved/affected this

Comment 9

[Benjamin Smedberg]

Resolving old bugs which are likely not relevant any more, since NPAPI plugins are deprecated.