Closed Bug 823175 Opened 9 years ago Closed 9 years ago

Add a method to return the next sub domain of a given host

Categories

(Core :: Networking: DNS, defect)

Product:
Core
Component:
Networking: DNS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla21

People

(Reporter: mounir, Assigned: mounir)

References

Details

(Keywords: dev-doc-needed)

Attachments

(1 file)

Patch
7.64 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
For example, "foo.bar.co.uk" => "bar.co.uk". It is needed in bug 816956 and that would be better to simply use the current logic of nsIEffectiveTLDService.
Attachment #693979 - Flags: review?(bzbarsky)
Comment on attachment 693979 [details] [diff] [review]
Patch

s/test.assert/test.throw/ in the test, perhaps?

> +     * Returns the next sub-domain of a host string.

Maybe "Returns the parent sub-domain of a host string"?  And maybe give an example or two to make it clear what's being returned...
Attachment #693979 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/cf0e172390b7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.