823226 - Add environment variables to control cycle collector logging

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: convert form globals to reading from environment variables

Comment 2

[Andrew McCreight [:mccr8]]

https://tbpl.mozilla.org/?tree=Try&rev=376936632f73

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 694083 [details] [diff] [review]
convert form globals to reading from environment variables

Suggestions welcome on env var names. No hurry on this review, as I'm on holiday until the 26th or so.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 694083 [details] [diff] [review]
convert form globals to reading from environment variables

>     nsCycleCollectorParams() :
>+        mLogAll      (PR_GetEnv("XPCOM_CC_LOG_ALL") != NULL),
>+        mLogShutdown (PR_GetEnv("XPCOM_CC_LOG_SHUTDOWN") != NULL),
>+        mAllTracesAtShutdown (PR_GetEnv("XPCOM_CC_ALL_TRACES_AT_SHUTDOWN") != NULL),
!= NULL is not pretty but let's fix coding style elsewhere.

Comment 5

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d29b182e169e

This page should probably be updated:
https://wiki.mozilla.org/Performance:Leak_Tools#Cycle_collector_heap_dump

Really, heap dumping needs to be documented separately. There's a page around somewhere.

Comment 6

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

https://hg.mozilla.org/mozilla-central/rev/d29b182e169e