Add environment variables to control cycle collector logging

RESOLVED FIXED in mozilla20

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Blocks: 1 bug, {dev-doc-needed})

unspecified
mozilla20
dev-doc-needed
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Assignee: nobody → continuation
(Assignee)

Comment 1

5 years ago
Created attachment 694083 [details] [diff] [review]
convert form globals to reading from environment variables
(Assignee)

Updated

5 years ago
Attachment #694083 - Flags: review?
(Assignee)

Comment 3

5 years ago
Comment on attachment 694083 [details] [diff] [review]
convert form globals to reading from environment variables

Suggestions welcome on env var names. No hurry on this review, as I'm on holiday until the 26th or so.
Attachment #694083 - Flags: review? → review?(bugs)

Comment 4

5 years ago
Comment on attachment 694083 [details] [diff] [review]
convert form globals to reading from environment variables

>     nsCycleCollectorParams() :
>+        mLogAll      (PR_GetEnv("XPCOM_CC_LOG_ALL") != NULL),
>+        mLogShutdown (PR_GetEnv("XPCOM_CC_LOG_SHUTDOWN") != NULL),
>+        mAllTracesAtShutdown (PR_GetEnv("XPCOM_CC_ALL_TRACES_AT_SHUTDOWN") != NULL),
!= NULL is not pretty but let's fix coding style elsewhere.
Attachment #694083 - Flags: review?(bugs) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d29b182e169e

This page should probably be updated:
https://wiki.mozilla.org/Performance:Leak_Tools#Cycle_collector_heap_dump

Really, heap dumping needs to be documented separately. There's a page around somewhere.
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/d29b182e169e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.