823240 - Include <sys/proc.h> on OpenBSD to get P_TRACED definition

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Landry Breuil (:gaston)]

Since rev 1.127 of <sys/sysctl.h> (see http://www.openbsd.org/cgi-bin/cvsweb/src/sys/sys/sysctl.h) <sys/proc.h> is not automatically included when <sys/sysctl.h> is included. Thus build of ipc/chromium/src/base/debug_util_posix.cc fails :

/usr/obj/firefox-18.0beta3/mozilla-beta/ipc/chromium/src/base/debug_util_posix.cc:103:37: error: use of undeclared identifier 'P_TRACED'
  being_debugged = (info.KP_FLAGS & P_TRACED) != 0;

including the missing #include fixes the build.

Comment 1

[Landry Breuil (:gaston)]

Attachment: Include sys/proc.h on OpenBSD

Comment 2

[Landry Breuil (:gaston)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b94cd856c59

Comment 3

[Landry Breuil (:gaston)]

Comment on attachment 694051 [details] [diff] [review]
Include sys/proc.h on OpenBSD

[Approval Request Comment]
Bug caused by (feature/regressing bug #): OpenBSD's r1.127 of sys/sysctl.h
User impact if declined: Local patch to carry on OpenBSD for the next two releases, unhappy maintainer (me)
Testing completed (on m-c, etc.): in progress
Risk to taking this patch (and alternatives if risky): none
String or UUID changes made by this patch: none

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8b94cd856c59

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 694051 [details] [diff] [review]
Include sys/proc.h on OpenBSD

Since this is #def'd, we can take this for FF18. Please land as soon as possible, and no later than 12/26 to make it into FF18.

Comment 6

[Landry Breuil (:gaston)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/150b5d0c9406
https://hg.mozilla.org/releases/mozilla-beta/rev/7fc3c3d65b6a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/7fc3c3d65b6a