Closed
Bug 823240
Opened 8 years ago
Closed 8 years ago
Include <sys/proc.h> on OpenBSD to get P_TRACED definition
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: gaston, Assigned: gaston)
Details
Attachments
(1 file)
817 bytes,
patch
|
cjones
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Since rev 1.127 of <sys/sysctl.h> (see http://www.openbsd.org/cgi-bin/cvsweb/src/sys/sys/sysctl.h) <sys/proc.h> is not automatically included when <sys/sysctl.h> is included. Thus build of ipc/chromium/src/base/debug_util_posix.cc fails : /usr/obj/firefox-18.0beta3/mozilla-beta/ipc/chromium/src/base/debug_util_posix.cc:103:37: error: use of undeclared identifier 'P_TRACED' being_debugged = (info.KP_FLAGS & P_TRACED) != 0; including the missing #include fixes the build.
Assignee | ||
Comment 1•8 years ago
|
||
Assignee: nobody → landry
Attachment #694051 -
Flags: review?(jones.chris.g)
Assignee | ||
Updated•8 years ago
|
Attachment #694051 -
Flags: review?(jones.chris.g) → review+
Assignee | ||
Comment 2•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b94cd856c59
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 694051 [details] [diff] [review] Include sys/proc.h on OpenBSD [Approval Request Comment] Bug caused by (feature/regressing bug #): OpenBSD's r1.127 of sys/sysctl.h User impact if declined: Local patch to carry on OpenBSD for the next two releases, unhappy maintainer (me) Testing completed (on m-c, etc.): in progress Risk to taking this patch (and alternatives if risky): none String or UUID changes made by this patch: none
Attachment #694051 -
Flags: approval-mozilla-beta?
Attachment #694051 -
Flags: approval-mozilla-aurora?
Comment 4•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8b94cd856c59
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Comment 5•8 years ago
|
||
Comment on attachment 694051 [details] [diff] [review] Include sys/proc.h on OpenBSD Since this is #def'd, we can take this for FF18. Please land as soon as possible, and no later than 12/26 to make it into FF18.
Attachment #694051 -
Flags: approval-mozilla-beta?
Attachment #694051 -
Flags: approval-mozilla-beta+
Attachment #694051 -
Flags: approval-mozilla-aurora?
Attachment #694051 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/150b5d0c9406 https://hg.mozilla.org/releases/mozilla-beta/rev/7fc3c3d65b6a
Comment 7•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/7fc3c3d65b6a
status-b2g18:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•