Closed
Bug 823258
Opened 11 years ago
Closed 11 years ago
Asking for a PROMPT_ACTION for a privileged API in a privileged packaged app - remember my choice default is incorrect
Categories
(Firefox OS Graveyard :: General, defect, P2)
Tracking
(blocking-basecamp:+, firefox19 fixed, firefox20 fixed, b2g18 fixed)
People
(Reporter: jsmith, Assigned: gwagner)
Details
(Whiteboard: interaction, UX-P2)
Attachments
(1 file)
1.05 KB,
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
Build: B2G 18 12/19/2012 Device: Unagi Steps: 1. Install a privileged app here - https://marketplace-dev.allizom.org/app/privileged-app-test/?src=mkt-search 2. Launch the packaged app 3. Select device storage test Expected: A permission prompt should appear defaulting to remember my choice. Actual: The permission prompt does not default to remember my choice. Additional Notes: This was originally a v1 requirement for privileged apps - remember my choice should set by default when requesting a permission to a web api with PROMPT_ACTION within a privileged app.
Reporter | ||
Comment 1•11 years ago
|
||
Personally, I wouldn't block on this for v1 ship, but this was a product requirement originally. Sending this into triage just in case.
blocking-basecamp: --- → ?
Reporter | ||
Comment 2•11 years ago
|
||
needinfo on Josh for input, as I pulled this out of his specs
Flags: needinfo?(jcarpenter)
Comment 3•11 years ago
|
||
Triage: BB-, tracking-b2g18+, please renom if UX has concerns
blocking-basecamp: ? → -
tracking-b2g18:
--- → +
Reporter | ||
Comment 4•11 years ago
|
||
(In reply to Joe Cheng from comment #3) > Triage: BB-, tracking-b2g18+, please renom if UX has concerns Requires a product decision. Triage argument given is irrelevant. Back into triage it goes.
Comment 5•11 years ago
|
||
Jason minused and if UX has concern they will renominate.
blocking-basecamp: ? → -
Comment 6•11 years ago
|
||
Per Jason, the default for privileged apps should be: Remember by choice = ON. Nominating: * This is incorrect implementation of a well defined spec * This is a security issue (signal to noise ratio undermines user faith in—and attention paid to—security prompts) * This is a usability issue (high level of user frustation at repeated prompts for important apps) * LOE should be relatively low (simply toggle the default value for privileged apps). Also adding needsinfo for Lucas Adamski to chime in.
blocking-basecamp: - → ?
Flags: needinfo?(jcarpenter) → needinfo?(ladamski)
Whiteboard: interaction, UX-P2
Comment 7•11 years ago
|
||
I agree we should fix this, this is a 1 line low risk fix that greatly enhances usability of permissions for privileged apps.
blocking-basecamp: ? → +
Flags: needinfo?(ladamski)
Updated•11 years ago
|
Assignee: nobody → anygregor
Priority: -- → P2
Target Milestone: --- → B2G C3 (12dec-1jan)
Assignee | ||
Comment 8•11 years ago
|
||
You also need the patch from bug 823397 here for testing.
Attachment #694992 -
Flags: review?(fabrice)
Assignee | ||
Comment 9•11 years ago
|
||
BTW thanks Jason for the simple testcases!
Updated•11 years ago
|
Attachment #694992 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 10•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f870bc01fbdf
Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(pdolanjski)
Reporter | ||
Updated•11 years ago
|
Component: Gaia::System → General
Comment 11•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f870bc01fbdf
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 12•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/35dc57c3e1e5 https://hg.mozilla.org/releases/mozilla-b2g18/rev/0390311f8ce3
Reporter | ||
Comment 13•11 years ago
|
||
Verified on 12/28 build with device storage & contacts api tests in a privileged app.
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in
before you can comment on or make changes to this bug.
Description
•