823356 - toolkit/places - Firefox aborts due to an assertion in nsNavHistoryResult

Status: RESOLVED DUPLICATE of bug 992670

(Toolkit :: Places, defect)

Description

[Catalin Iordache]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:17.0) Gecko/20100101 Firefox/17.0
Build ID: 20121129151900

Steps to reproduce:

Trying to resolve a build warning. This land to a bigger problem. When you try to resolve:  toolkit/components/places/nsNavHistoryResult.cpp:1630:5 [-Wtype-limits] comparison of unsigned expression >= 0 is always true with something like : (mAccessCount >= mChildren[aIndex]->mAccessCount), it crashes.

Comment 1

[Scoobidiver (away)]

Do you have a crash ID (go to about:crashes)?

Comment 2

[Marco Bonardo [:mak]]

the crash is just an abort caused by the assertion. It's expected, we have to figure out what activates the assertion though.

Comment 3

[Marco Bonardo [:mak]]

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/nsNavHistoryResult.cpp#1629

basically mAccessCount should always be >= mChildren[aIndex]->mAccessCount but in some situation that doesn't happen and the calculation is "wrong" cause mAccessCount is unsigned

Comment 4

[Daniel Holbert [:dholbert]]

The build warning in question here is now:
{
nsNavHistoryResult.cpp:1466:32: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
}

Comment 5

[:Cykesiopka]

The assertion was handled in Bug 992670, and Bug 1049797 is on file for the crashing mentioned in this bug and Bug 992670.