823427 - [Bluetooth] Remove unnecessary buffer in ObexBase.cpp

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Eric Chou [:ericchou] [:echou]]

In the function ParseHeaders() of dom/bluetooth/ObexBase.cpp, a buffer [content] is allocated to keep retrieved data. This buffer would be passed into ctor of ObexHeader, but actually we could just pass the original pointer in since another buffer would be allocated in ctor of ObexHeader.

This is a follow-up to bug 814341. Please see comment 8 in that bug for more information.

Comment 1

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

(In reply to Eric Chou [:ericchou] [:echou] from comment #0)
> This is a follow-up to bug 814341. Please see comment 8 in that bug for more
> information.

For convenience: that's bug 814341 comment 8.

(taking advantage of bugzilla's auto-linkification of "bug-x-comment-n" strings :)  )

Comment 2

[Eric Chou [:ericchou] [:echou]]

(In reply to Daniel Holbert [:dholbert] from comment #1)
> (In reply to Eric Chou [:ericchou] [:echou] from comment #0)
> > This is a follow-up to bug 814341. Please see comment 8 in that bug for more
> > information.
> 
> For convenience: that's bug 814341 comment 8.
> 
> (taking advantage of bugzilla's auto-linkification of "bug-x-comment-n"
> strings :)  )

Oh, I didn't know that, thanks again. :)

Comment 3

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: removed unnecessary buffer

* Removed unnecessary buffer. 
* Daniel, please review my code to see if I misunderstood anything.
  Gina, please review my code to ensure that I didn't break OPP functionalities.

Comment 4

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 694268 [details] [diff] [review]
patch 1: v1: removed unnecessary buffer

Review of attachment 694268 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good :)

Comment 5

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

Comment on attachment 694268 [details] [diff] [review]
patch 1: v1: removed unnecessary buffer

Yup, that's what I had in mind. Thanks!

Comment 6

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c4bbe142937e

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/c4bbe142937e