Closed Bug 823448 Opened 12 years ago Closed 5 years ago

Show exact replacement of code and not only the addition

Categories

(bugzilla.mozilla.org :: Splinter, defect, P5)

Production
defect

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: whimboo, Unassigned)

Details

(Whiteboard: [ateamtrack: p=bugzilla q=2013q2 m=3])

As you can see on bug 809431 comment 6 there is only the addition of code shown:

> Review of attachment 693482 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: tests/functional/testAwesomeBar/testGoButton.js
> @@ +50,5 @@
> >    expect.ok(!utils.isDisplayed(controller, goButton), "Go button is hidden");
> >  
> >    // Check if an element with an id of 'organization' exists
> >    var pageElement = new elementslib.ID(controller.tabs.activeTab, "organization");
> > +  assert.ok(pageElement, "'Organization' element has been found");

But it was a replacement actually. So it's important to merge both sides for the final display in the bug comment.
Whiteboard: [ateamtrack: p=bugzilla q=2 m=3]
Whiteboard: [ateamtrack: p=bugzilla q=2 m=3] → [ateamtrack: p=bugzilla q=2013q2 m=3]
Assignee: nobody → glob
this requires treating each comment as Splinter.CHANGED, and fixing up the @@ lines for the created patch.  i've given it a shot, but as it isn't a trivial change i'll put this back onto the pile for now.
Assignee: glob → nobody
Blocks: 885464
No longer blocks: 885464
Priority: -- → P5

Splinter is retiring.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.