Closed
Bug 823472
Opened 12 years ago
Closed 11 years ago
[FTU UX VD] Replace "Hello" bubbles illustration asset in lenguage selection
Categories
(Firefox OS Graveyard :: Gaia::First Time Experience, defect)
Tracking
(b2g18 fixed)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
b2g18 | --- | fixed |
People
(Reporter: vicky, Assigned: fcampo)
Details
(Keywords: polish, Whiteboard: visual design, uxbranch, landed in uxbranch, qa-verifed, yedo)
Attachments
(3 files)
30.31 KB,
image/png
|
Details | |
30.32 KB,
image/png
|
Details | |
296 bytes,
text/html
|
sjochimek
:
review+
vingtetun
:
approval-gaia-v1+
|
Details |
Please replace that asset in lenguage selection. THe new asset replaces the OPen Sans font, and uses the MozTT one. Find attached the file.
Comment 1•11 years ago
|
||
Landed in uxbranch: https://github.com/gordonbrander/gaia/commit/52844c866907a35be646cfc03f2c4055c841b899
Assignee: nobody → fernando.campo
Whiteboard: Visual design → visual design, uxbranch, landed in uxbranch
qa-verified
Whiteboard: visual design, uxbranch, landed in uxbranch → visual design, uxbranch, landed in uxbranch, qa-verifed
Comment 3•11 years ago
|
||
Hi Fernando or Sam, after the Pull Request corresponding revision can you land the patch in master? As there is no clear answers about the UX branch purpose right now, it'd be better to land it in master so after that, we can ask for uplifting the patch to v1-train. Otherwise I am afraid the work done will be lost and it will not land in time or never in the commercial release v1.1.
Assignee | ||
Comment 4•11 years ago
|
||
We have a conflict on this one, as the current patch modifies an image that no longer exists (was changed time ago), so I'm waiting for Victoria to finish her PTO so she can guide us on here(In reply to Maria Angeles Oteo:oteo from comment #3) > Hi Fernando or Sam, after the Pull Request corresponding revision can you > land the patch in master?
Flags: needinfo?(vpg)
Reporter | ||
Comment 5•11 years ago
|
||
Flags: needinfo?(vpg)
Assignee | ||
Comment 6•11 years ago
|
||
New image added, PR to master
Attachment #732754 -
Flags: review?(sjochimek)
Updated•11 years ago
|
Attachment #732754 -
Flags: review?(sjochimek) → review+
Comment 7•11 years ago
|
||
Comment on attachment 732754 [details] Link to https://github.com/mozilla-b2g/gaia/pull/8940 Master commit is https://github.com/mozilla-b2g/gaia/commit/40608b6ea83347c4a0dfc4e4d1f4571d99b88d9f NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): - User impact if declined: - Testing completed: Yes Risk to taking this patch (and alternatives if risky): low risk, mostly an image updates String or UUID changes made by this patch: -
Attachment #732754 -
Flags: approval-gaia-v1?(21)
Updated•11 years ago
|
Whiteboard: visual design, uxbranch, landed in uxbranch, qa-verifed → visual design, uxbranch, landed in uxbranch, qa-verifed, yedo
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 8•11 years ago
|
||
Comment on attachment 732754 [details] Link to https://github.com/mozilla-b2g/gaia/pull/8940 This comes from the UX branch process where QA has already checked that it works. a=me.
Attachment #732754 -
Flags: approval-gaia-v1?(21) → approval-gaia-v1+
Master build : 2013-04-05-03-05-43 name="mozilla-central" revision="55f9e3e3dae7" name="integration/gaia-central" revision="2005e026bdae" "gecko.git" revision="66b64f47a4eac1bd4f5ea6748b42ddf732297550" "gaia.git" revision="15468abcba0dd2549f0c102df887a5c049b9c641" Unagi
Status: RESOLVED → VERIFIED
status-b2g18:
--- → affected
Comment 10•11 years ago
|
||
Uplifted commit 40608b6ea83347c4a0dfc4e4d1f4571d99b88d9f as: v1-train: 6438e00da8064c5ad3b61fef52bb6b1c7e6d59d4
You need to log in
before you can comment on or make changes to this bug.
Description
•