Closed Bug 823540 Opened 13 years ago Closed 13 years ago

use absolute URLs for the shared resources in the Camera app

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect, P2)

x86_64
Gonk (Firefox OS)
defect

Tracking

(blocking-basecamp:+)

VERIFIED FIXED
B2G C3 (12dec-1jan)
blocking-basecamp +

People

(Reporter: kaze, Assigned: kaze)

References

Details

Attachments

(1 file)

The Camera app (apps/camera) is copied at build time into the System app (apps/system/camera). As the shared resources in the Camera are using relative paths, we currently rely on a dirty hack in the Makefile to add “../” with a |sed -e| call. This is ugly and not necessary: using "/shared" would always work, regardless of the position of the HTML file in the file structure. This blocks bug 821691.
Attached file patch proposal
This bug should be considered BB+ as it blocks a BB+ item.
Assignee: nobody → kaze
Attachment #694392 - Flags: review?(poirot.alex)
Comment on attachment 694392 [details] patch proposal Looks good, I'd even dream to do that on the whole codebase :o Tested camera by taking pictures and deleting them, works fine.
Attachment #694392 - Flags: review?(poirot.alex) → review+
blocking-basecamp: --- → +
Priority: -- → P2
Target Milestone: --- → B2G C3 (12dec-1jan)
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Confirmed changes as well as camera functionality. Verified build 20130110070201.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: