use absolute URLs for the shared resources in the Camera app

VERIFIED FIXED in B2G C3 (12dec-1jan)

Status

Firefox OS
Gaia::Camera
P2
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: kaze, Assigned: kaze)

Tracking

unspecified
B2G C3 (12dec-1jan)
x86_64
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-basecamp:+)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The Camera app (apps/camera) is copied at build time into the System app (apps/system/camera). As the shared resources in the Camera are using relative paths, we currently rely on a dirty hack in the Makefile to add “../” with a |sed -e| call.

This is ugly and not necessary: using "/shared" would always work, regardless of the position of the HTML file in the file structure.

This blocks bug 821691.
(Assignee)

Comment 1

5 years ago
Created attachment 694392 [details]
patch proposal

This bug should be considered BB+ as it blocks a BB+ item.
Assignee: nobody → kaze
Attachment #694392 - Flags: review?(poirot.alex)
Comment on attachment 694392 [details]
patch proposal

Looks good, I'd even dream to do that on the whole codebase :o

Tested camera by taking pictures and deleting them, works fine.
Attachment #694392 - Flags: review?(poirot.alex) → review+
blocking-basecamp: --- → +
Priority: -- → P2
Target Milestone: --- → B2G C3 (12dec-1jan)
(Assignee)

Comment 3

5 years ago
https://github.com/mozilla-b2g/gaia/commit/dca559b891d7593a4e9f99b7d484cacfb26d55be
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Confirmed changes as well as camera functionality.
Verified build 20130110070201.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.