823549 - Make NodeIterator.detach() a no-op

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Anne (:annevk)]

Just as we did with Range.detach(), NodeIterator.detach() should do nothing. (Removing it altogether seems unwise.)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 2

[Mounir Lamouri (:mounir)]

Comment on attachment 704324 [details] [diff] [review]
Patch v1

Review of attachment 704324 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, with the error being reported to the console. Feel free to open a follow-up to address the comment but please address it :)

::: content/base/src/nsNodeIterator.cpp
@@ +266,1 @@
>      return NS_OK;

Should we add a message in the console saying that this method doesn't do anything any more?

By the way, why doesn't the spec call the method deprecated?

::: content/base/test/test_NodeIterator_basics_filters.xhtml
@@ +121,5 @@
>        iterator.nextNode();
>      try {
>        iterator[method]();
> +      ok(true, "Able to call " + method + " on a detached NodeIterator");
> +    } catch (x) { ok(false, x) }

A comment saying that the node isn't really detached would be nice.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/4854f48986eb

Comment 4

[Kohei Yoshino [:kohei]]

I've added this bug to the compatibility doc. Please correct the info if wrong.
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_22

Also, please update the following docs:
https://developer.mozilla.org/en-US/docs/DOM/NodeIterator.detach

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://developer.mozilla.org/en-US/docs/DOM/NodeIterator.detach too

Comment 6

[Jean-Yves Perrier [:teoli]]

https://developer.mozilla.org/en-US/docs/DOM/NodeIterator.detach done