823553 - MSVC 2008 (VC9) builds are failing with "can't take a reference to a reference" after bug 819791

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Justin Lebar (not reading bugmail)]

Ginn Chen and Philip Chee reported this failure in bug 819791:

> I'm seeing similar errors with MSVC2008SP1 :
> cc:\t1\hg\comm-central\mozilla\storage\src\Variant.h(318) : warning C4181: qualifier applied to reference type; ignored
> :\t1\hg\comm-central\mozilla\storage\src\Variant.h(318) : warning C4181: qualifier applied to reference type; ignored
>          c:/t1/hg/comm-central/mozilla/storage/src/mozStorageRow.cpp(46) : see reference to class template instantiation 'mozilla::storage::Variant<DataType>' being compiled
>        c:/t1/hg/comm-central/mozilla/storage/src/mozStoragePrivateHelpers.cpp(128) : see reference to class template instantiation 'mozilla::storage::Variant<DataType>' being compiled
>          with
>        with
>          [
>        [
>              DataType=nsString
>            DataType=nsString
>          ]
>        ]
> cc:\t1\hg\comm-central\mozilla\storage\src\Variant.h(318) : warning C4181: qualifier applied to reference type; ignored
> :\t1\hg\comm-central\mozilla\storage\src\Variant.h(318) : warning C4181: qualifier applied to reference type; ignored
> cc:\t1\hg\comm-central\mozilla\storage\src\Variant.h(318) : error C2529: 'aData' : reference to reference is illegal
> :\t1\hg\comm-central\mozilla\storage\src\Variant.h(318) : error C2529: 'aData' : reference to reference is illegal
> cc:/t1/hg/comm-central/mozilla/storage/src/mozStoragePrivateHelpers.cpp(128) : error C2664: 'mozilla::storage::Variant<DataType>::Variant(mozilla::storage::variant_storage_traits<nsString>::ConstructorType (&))' : cannot convert parameter 1 from 'nsDependentJSString' to 'mozilla::storage::variant_storage_traits<nsString>::ConstructorType (&)'
> :/t1/hg/comm-central/mozilla/storage/src/mozStorageRow.cpp(46) : error C2664: 'mozilla::storage::Variant<DataType>::Variant mozilla::storage::variant_storage_traits<nsString>::ConstructorType (&))' :cannot convert parameter 1 from 'nsDependentString' to 'mozilla::storage::variant_storage_traits<nsString>::ConstructorType (&)'
>          with
>        with
>          [
>        [
>              DataType=nsString
>            DataType=nsString
>          ]
>        ]
> 
> etc etc.

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Fix build error in Variant.h on MSVC 2008 and Solaris by not taking double-references.

review: :mak

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 694466 [details] [diff] [review]
Fix build error in Variant.h on MSVC 2008 and Solaris by not taking double-references.

Review of attachment 694466 [details] [diff] [review]:
-----------------------------------------------------------------

it looks ok, provided the compilers are happy with it, thanks for fixing this.

Comment 3

[Justin Lebar (not reading bugmail)]

Thank you for the review!

I'm pretty sure this will fix the build errors, but please let me know if it doesn't.

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e71802dec3a

Comment 4

[Bill Gianopoulos [:WG9s]]

(In reply to Justin Lebar [:jlebar] (away 12/21-1/2) from comment #3)
> Thank you for the review!
> 
> I'm pretty sure this will fix the build errors, but please let me know if it
> doesn't.
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/4e71802dec3a

I can verify this fixes the build issues using MSVC 2008 (also known as VC9).  I can't speak for Solaris.

Comment 5

[Philip Chee]

Comment on attachment 694466 [details] [diff] [review]
Fix build error in Variant.h on MSVC 2008 and Solaris by not taking double-references.

Managed to get a successful build with this patch
Thanks Muchly!
f=me

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/4e71802dec3a