Update Mouse Wheel preferences help after bug 782143 and bug 819652

RESOLVED FIXED in seamonkey2.17

Status

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

Trunk
seamonkey2.17
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Bug 819652 changed the Mouse Wheel preferences pane. Help needs to be adapted accordingly.
819652? Did we ever update it after bug 782143? Oops...
Posted patch Possible patch (obsolete) — Splinter Review
Attachment #694529 - Flags: feedback?(jh)
Depends on: 782143
Summary: Update Mouse Wheel preferences help after bug 819652 → Update Mouse Wheel preferences help after bug 782143 and bug 819652
Comment on attachment 694529 [details] [diff] [review]
Possible patch

Review of attachment 694529 [details] [diff] [review]:
-----------------------------------------------------------------

Too many issues for a positive review or feedback, but thank you very much for getting to this so fast! :-)

::: suite/locales/en-US/chrome/common/help/cs_nav_prefs_advanced.xhtml
@@ +548,5 @@
>  <ul>
>    <li>Select <q>No modifier key</q> or select a key that you want to use
>      along with the mouse wheel. Use the checkboxes below to configure mouse
>      wheel behavior:
>      

Nit: Remove whitespace while we're here (see Splinter Review).

@@ +550,5 @@
>      along with the mouse wheel. Use the checkboxes below to configure mouse
>      wheel behavior:
>      
>      <ul>
> +      <li><strong>Same as vertical</strong>: Choose this when your mouse has a

Should read "Same as vertical scrolling".

@@ +553,5 @@
>      <ul>
> +      <li><strong>Same as vertical</strong>: Choose this when your mouse has a
> +        single control that provides both vertical and horizontal scrolling.
> +        If your mouse has a separate horizontal scrolling control then you can
> +        choose to use assign a different function to it.</li>

Just "assign", I assume? ;-)

@@ +570,5 @@
>  
> +    <p>Use the <strong>Mouse wheel speed</strong> option to increase or
> +      decrease the responsiveness of the wheel. The <strong>Reverse
> +      direction</strong> option provides a convenient way of choosing a
> +      negative wheel speed.</p>

I wonder whether speed can be negative at all (at least in common speech; I'm even less sure about physics). I think it's wrong in this context. Maybe "reverse scrolling"?
Attachment #694529 - Flags: feedback?(jh) → feedback-
(In reply to Jens Hatlak from comment #3)
> (From update of attachment 694529 [details] [diff] [review])
> > +      <li><strong>Same as vertical</strong>: Choose this when your mouse has a
> Should read "Same as vertical scrolling".
Indeed.

> > +        If your mouse has a separate horizontal scrolling control then you can
> > +        choose to use assign a different function to it.</li>
> Just "assign", I assume? ;-)
Yeah, I changed my mind over the wording and didn't fix it properly.

> > +    <p>Use the <strong>Mouse wheel speed</strong> option to increase or
> > +      decrease the responsiveness of the wheel. The <strong>Reverse
> > +      direction</strong> option provides a convenient way of choosing a
> > +      negative wheel speed.</p>
> I wonder whether speed can be negative at all (at least in common speech;
> I'm even less sure about physics). I think it's wrong in this context. Maybe
> "reverse scrolling"?
I couldn't think of a better way of expressing this. How about:
Use the *Mouse wheel speed* option to increase, decrease or completely reverse the response of the wheel.
Flags: needinfo?
(In reply to neil@parkwaycc.co.uk from comment #4)
> I couldn't think of a better way of expressing this. How about:
> Use the *Mouse wheel speed* option to increase, decrease or completely
> reverse the response of the wheel.

I like "responsiveness" better than "response" in connection with in/decrease. Also, the "completely" sounds too much like "totally" to me, i.e. doesn't really add much value in my eyes.

How about this:
"Use the *Mouse wheel speed* option to increase or decrease the responsiveness of the wheel. Use *Reverse direction* to change the scroll direction."
Flags: needinfo?
(In reply to Jens Hatlak from comment #5)
> (In reply to comment #4)
> > I couldn't think of a better way of expressing this. How about:
> > Use the *Mouse wheel speed* option to increase, decrease or completely
> > reverse the response of the wheel.
> 
> I like "responsiveness" better than "response" in connection with
> in/decrease. Also, the "completely" sounds too much like "totally" to me,
> i.e. doesn't really add much value in my eyes.
> 
> How about this:
> "Use the *Mouse wheel speed* option to increase or decrease the
> responsiveness of the wheel. Use *Reverse direction* to change the scroll
> direction."

Well, the point is that *Reverse direction* works by negating the speed...
I think I should let the help peers fight amongst themselves ;-)
OK, so you can either use negative numbers in "Mouse wheel speed" or select the "Reverse direction" checkbox which will then make the "Mouse wheel speed" numbers negative...

How about:
"Use the *Mouse wheel speed* option to adjust the response of the wheel. To reverse the scroll direction, use negative numbers or select *Reverse direction*."
(In reply to neil@parkwaycc.co.uk from comment #6)
> Well, the point is that *Reverse direction* works by negating the speed...

Heh you're right, didn't check that! But that's mostly a technical aspect.

(In reply to Stefan [:stefanh] from comment #8)
> How about:
> "Use the *Mouse wheel speed* option to adjust the response of the wheel. To
> reverse the scroll direction, use negative numbers or select *Reverse
> direction*."

This has my vote, thanks! :-)

[I'll let the English native speakers decide whether "response" or "responsiveness" fits better in this context.]
(In reply to Jens Hatlak (:InvisibleSmiley) from comment #9)
> (In reply to neil@parkwaycc.co.uk from comment #6)
> > Well, the point is that *Reverse direction* works by negating the speed...
> 
> Heh you're right, didn't check that! But that's mostly a technical aspect.
> 
> (In reply to Stefan [:stefanh] from comment #8)
> > How about:
> > "Use the *Mouse wheel speed* option to adjust the response of the wheel. To
> > reverse the scroll direction, use negative numbers or select *Reverse
> > direction*."
> 
> This has my vote, thanks! :-)
> 
> [I'll let the English native speakers decide whether "response" or
> "responsiveness" fits better in this context.]

My preference would be for responsiveness
I know this is mostly yours, but I don't speak in your name, so let's *reverse the direction* of the review situation. :-)
Assignee: nobody → jh
Attachment #694529 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #695731 - Flags: review?(neil)
Comment on attachment 695731 [details] [diff] [review]
patch v2 [Checkin: Comment 15]

I hope the response, if not the responsiveness, of the review is satisfactory ;-)
Attachment #695731 - Flags: review?(neil) → review+
Bah, sorry I didn't catch this earlier: the last of the radio button labels, formerly "Make the text larger or smaller", actually reads "Zoom the page in or out" now.

Neil, are you OK with just applying the label change to the help file, or do you think the explanation needs to be adjusted, too?
Flags: needinfo?(neil)
(In reply to Jens Hatlak from comment #13)
> Bah, sorry I didn't catch this earlier: the last of the radio button labels,
> formerly "Make the text larger or smaller", actually reads "Zoom the page in
> or out" now.
> 
> Neil, are you OK with just applying the label change to the help file, or do
> you think the explanation needs to be adjusted, too?

Well, ideally you would link to the help for the appearance - content - zoom only text checkbox, but that might be beyond the scope of this bug, in which case I would just remove the words "text on".
Flags: needinfo?(neil)
Comment on attachment 695731 [details] [diff] [review]
patch v2 [Checkin: Comment 15]

http://hg.mozilla.org/comm-central/rev/7e37758d13d9
with comments 13/14 addressed
Attachment #695731 - Attachment description: patch v2 → patch v2 [Checkin: Comment 15]
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.17
You need to log in before you can comment on or make changes to this bug.