Closed
Bug 823706
Opened 12 years ago
Closed 12 years ago
Remove global private browsing usage from pdf.js
Categories
(Firefox :: PDF Viewer, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jdm, Unassigned)
References
Details
(Whiteboard: [pdfjs-c-integration] https://github.com/mozilla/pdf.js/pull/2481)
Instead of checking the service, it should just import PrivateBrowsingUtils.jsm and use PrivateBrowsingUtils.isWindowPrivate on the relevant window object.
|
||
Comment 1•12 years ago
|
||
This patch basically does the job: https://github.com/mozilla/pdf.js/pull/2481 I've commented there on a few things that need to be improved there.
Blocks: 818800
|
||
Updated•12 years ago
|
Whiteboard: [pdfjs-c-integration] https://github.com/mozilla/pdf.js/pull/2481
|
|
||
Comment 2•12 years ago
|
||
Also see https://github.com/mozilla/pdf.js/pull/2498.
|
|
||
Comment 3•12 years ago
|
||
Can I land the patch in https://github.com/mozilla/pdf.js/pull/2481 on mozilla-central now that it has landed on pdf.js's master? We really need this to be fixed on m-c as soon as possible.
|
||
Comment 4•12 years ago
|
||
The fix(though not your smaller one) will be landed in bug 824174.
|
|
||
Comment 5•12 years ago
|
||
Great, thanks!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•