Closed
Bug 823716
Opened 13 years ago
Closed 12 years ago
Duplicated "tscroll" name for tests on graphs server
Categories
(Webtools Graveyard :: Graph Server, defect)
Webtools Graveyard
Graph Server
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: andershol, Assigned: andershol)
Details
Attachments
(1 file, 1 obsolete file)
2.29 KB,
patch
|
andershol
:
review+
|
Details | Diff | Splinter Review |
The tests with the names "tscroll" and "tscroll_paint" (ids 71 and 112) have the same pretty_name "tscroll" on the graphs server. Looking at other "..._paint" tests, the pretty_name for "tscroll_paint" should probably be "tscroll MozAfterPaint".
Also, the test "tscrollr_paint" should probably have its the pretty_name changed from "tscroll Row Major" to "tscroll Row Major MozAfterPaint", and similar for "tscroll.2_paint" (these are the only "..._paint" tests whit no "Paint" in the pretty_name).
Besides applying the patch, this should be fixed in the database:
update tests
set pretty_name='tscroll MozAfterPaint'
where name='tscroll_paint';
update tests
set pretty_name='tscroll 2 MozAfterPaint'
where name='tscroll.2_paint';
update tests
set pretty_name='tscroll Row Major MozAfterPaint'
where name='tscrollr_paint';
Attachment #694571 -
Attachment is patch: true
Attachment #694571 -
Flags: review?(rhelmer)
Updated•13 years ago
|
Attachment #694571 -
Flags: review?(rhelmer) → review+
Only changing the check-in message with bug id and reviewer.
Attachment #694571 -
Attachment is obsolete: true
Attachment #694736 -
Flags: review+
Keywords: checkin-needed
Whiteboard: [for the /graphs/ repository]
Updated•13 years ago
|
Summary: Dublicated "tscroll" name for tests on graphs server → Duplicated "tscroll" name for tests on graphs server
Comment 2•12 years ago
|
||
Assignee: nobody → andershol
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [for the /graphs/ repository]
Comment 3•12 years ago
|
||
this needs to be deployed to the graph servers, was that done?
*cough*This would be easy to see if bug 824228 had been accepted.*cough*
Opening http://graphs.mozilla.org/api/test?attribute=short in a browser and searching for '"tscroll' shows that it has not since the pretty_names ('name' in the json) do not contain MozAfterPaint.
My previous comment could come across a impolite. I am sorry about that.
(In reply to Joel Maher (:jmaher) from comment #3)
> this needs to be deployed to the graph servers, was that done?
What would one do to get it deployed?
Comment 6•12 years ago
|
||
we need to file a bug similar to:
https://bugzilla.mozilla.org/show_bug.cgi?id=822280
Thank you for the pointer. Filed bug 834853.
Updated•9 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•