823716 - Duplicated "tscroll" name for tests on graphs server

Status: RESOLVED FIXED

Description

[andershol]

Created attachment 694571 [details] [diff] [review]
Fix dublicated pretty_name and missing MozAfterPaint

The tests with the names "tscroll" and "tscroll_paint" (ids 71 and 112) have the same pretty_name "tscroll" on the graphs server. Looking at other "..._paint" tests, the pretty_name for "tscroll_paint" should probably be "tscroll MozAfterPaint".

Also, the test "tscrollr_paint" should probably have its the pretty_name changed from "tscroll Row Major" to "tscroll Row Major MozAfterPaint", and similar for "tscroll.2_paint" (these are the only "..._paint" tests whit no "Paint" in the pretty_name).

Besides applying the patch, this should be fixed in the database:
update tests
  set pretty_name='tscroll MozAfterPaint'
  where name='tscroll_paint';
update tests
  set pretty_name='tscroll 2 MozAfterPaint'
  where name='tscroll.2_paint';
update tests
  set pretty_name='tscroll Row Major MozAfterPaint'
  where name='tscrollr_paint';

Comment 1

[andershol]

Created attachment 694736 [details] [diff] [review]
Fix dublicated pretty_name and missing MozAfterPaint (with bug id and reviewer)

Only changing the check-in message with bug id and reviewer.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/graphs/rev/1411d6d41387

Comment 3

[Joel Maher ( :jmaher ) (UTC-4)]

this needs to be deployed to the graph servers, was that done?

Comment 4

[andershol]

*cough*This would be easy to see if bug 824228 had been accepted.*cough*

Opening http://graphs.mozilla.org/api/test?attribute=short in a browser and searching for '"tscroll' shows that it has not since the pretty_names ('name' in the json) do not contain MozAfterPaint.

Comment 5

[andershol]

My previous comment could come across a impolite. I am sorry about that.

(In reply to Joel Maher (:jmaher) from comment #3)
> this needs to be deployed to the graph servers, was that done?

What would one do to get it deployed?

Comment 6

[Joel Maher ( :jmaher ) (UTC-4)]

we need to file a bug similar to:
https://bugzilla.mozilla.org/show_bug.cgi?id=822280

Comment 7

[andershol]

Thank you for the pointer. Filed bug 834853.