Closed Bug 823735 Opened 7 years ago Closed 7 years ago

Port test_cookies_privatebrowsing.js to the per-window PB APIs

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: ehsan, Assigned: andreshm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Blocks: pbngentest
Disabled the test for now: https://hg.mozilla.org/integration/mozilla-inbound/rev/ef9bd763ccd2
Whiteboard: [leave open]
There's no actual porting required; there are some obsolete references to Services.pb and the session pref, but the rest of the test is fine.
Assignee: nobody → andres
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #697130 - Flags: review?(josh)
Status: NEW → ASSIGNED
Comment on attachment 697130 [details] [diff] [review]
Patch v1

Review of attachment 697130 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/cookie/test/unit/xpcshell.ini
@@ +11,5 @@
>  [test_cookies_persistence.js]
>  [test_cookies_privatebrowsing.js]
>  skip-if = perwindowprivatebrowsing
> +[test_cookies_privatebrowsing_perwindowpb.js]
> +skip-if = !perwindowprivatebrowsing

This is not necessary. The test runs fine with per-window mode disabled.
Attachment #697130 - Flags: review?(josh) → review+
Attached patch Patch v2Splinter Review
Updated the patch, just removed the obsolete references.
Attachment #697130 - Attachment is obsolete: true
Keywords: checkin-needed
Whiteboard: [leave open]
https://hg.mozilla.org/mozilla-central/rev/1c794aeaf3d8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.