TextView can show images in them (wait.. what?). It's a good-yet-less-known feature of TextView that can reduce a large number of views that we use. http://developer.android.com/reference/android/widget/TextView.html#setCompoundDrawablesWithIntrinsicBounds%28int,%20int,%20int,%20int%29 We could clean up about:home by using this.
This reduces the PromoBox from: <LinearLayout> <ImageView/> <TextView/> </LinearLayout> to: <TextView/> Yes! Just that! :D
Assignee: nobody → sriram
Attachment #694623 - Flags: review?(mark.finkle)
Comment on attachment 694623 [details] [diff] [review] Part 1: PromoBox Nice
Attachment #694623 - Flags: review?(mark.finkle) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Summary: Compound Drawable for TextViews on about:home → Compound Drawable for PromoBox on about:home
You need to log in before you can comment on or make changes to this bug.