Closed
Bug 823781
Opened 12 years ago
Closed 12 years ago
Compound Drawable for PromoBox on about:home
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 20
People
(Reporter: sriram, Assigned: sriram)
References
Details
Attachments
(1 file)
|
10.32 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
TextView can show images in them (wait.. what?). It's a good-yet-less-known feature of TextView that can reduce a large number of views that we use. http://developer.android.com/reference/android/widget/TextView.html#setCompoundDrawablesWithIntrinsicBounds%28int,%20int,%20int,%20int%29 We could clean up about:home by using this.
|
Assignee | |
Comment 1•12 years ago
|
||
This reduces the PromoBox from: <LinearLayout> <ImageView/> <TextView/> </LinearLayout> to: <TextView/> Yes! Just that! :D
Assignee: nobody → sriram
Attachment #694623 -
Flags: review?(mark.finkle)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 694623 [details] [diff] [review] Part 1: PromoBox Nice
Attachment #694623 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/014b47f440c5
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/014b47f440c5
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
|
|
Assignee | |
Updated•12 years ago
|
Summary: Compound Drawable for TextViews on about:home → Compound Drawable for PromoBox on about:home
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•