823887 - IonMonkey: pre-increment on InlineFrameIterator does actually a post-increment

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Hannes Verschore [:h4writer]]

Noticed in bug 813784, but "++it" on InlineFrameIterator should first increment and return the incremented value. Currently that implemention returns the current value and increments afterwards.

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: patch

Comment 2

[Nicolas B. Pierron [:nbp]]

Comment on attachment 695446 [details] [diff] [review]
patch

Review of attachment 695446 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/IonFrames.cpp
@@ +956,1 @@
>      return iter;

You are no longer modifying |this|, I'll be surprised if this is working with the test suite.

return *this;

plus removing the copy and changing the return value to be a reference should do it ;)

Comment 3

[Hannes Verschore [:h4writer]]

Attachment: Patch

Ah you are fast today. I was actually making this adjusted patch already to remove this one :P

Comment 4

[Nicolas B. Pierron [:nbp]]

Comment on attachment 695448 [details] [diff] [review]
Patch

Review of attachment 695448 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/IonFrames.cpp
@@ +948,5 @@
>      framesRead_++;
>  }
>  
>  InlineFrameIterator
>  InlineFrameIterator::operator++()

nit: Add a reference to the returned type, to avoid copies of the iterator.

Comment 5

[Hannes Verschore [:h4writer]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e097dd1a2c38

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e097dd1a2c38