Closed Bug 823907 Opened 8 years ago Closed 8 years ago

Remove the "enabled everything (mozilla-central matching run)" option from TryChooser

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

(Keywords: sheriffing-P1, trychooser, Whiteboard: [capacity])

Attachments

(1 file)

Since:
* people can already click 2-3 "All" checkboxes for the same effect.
* it's too tempting a footgun imo
* it takes up additional screen estate (more of an issue now that we have many more mobile/b2g specific unit tests listed, with more to come)
Attached patch Patch v1Splinter Review
Attachment #694829 - Flags: review?(bgirard)
(Diff looks worse than it is; mainly whitespace changes)
IMO I'd vote to just use display:none and leave the feature in.
I don't think we should leave in code that isn't being used. If we ever wish to retrieve it, we're using a DCVS.
Attachment #694829 - Flags: review?(bgirard) → review+
(In reply to Ed Morley [UTC+0; email:edmorley@moco] from comment #4)
> I don't think we should leave in code that isn't being used. If we ever wish
> to retrieve it, we're using a DCVS.

In practice this doesn't always work as well. It causes merge conflicts and it's hard to remember what features are 'in the history'.
Depends on: 827810
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: Tools → General
You need to log in before you can comment on or make changes to this bug.