Closed
Bug 823907
Opened 12 years ago
Closed 11 years ago
Remove the "enabled everything (mozilla-central matching run)" option from TryChooser
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
(Keywords: sheriffing-P1, trychooser, Whiteboard: [capacity])
Attachments
(1 file)
|
5.84 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
Since: * people can already click 2-3 "All" checkboxes for the same effect. * it's too tempting a footgun imo * it takes up additional screen estate (more of an issue now that we have many more mobile/b2g specific unit tests listed, with more to come)
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #694829 -
Flags: review?(bgirard)
|
|
Assignee | |
Comment 2•12 years ago
|
||
(Diff looks worse than it is; mainly whitespace changes)
|
||
Comment 3•12 years ago
|
||
IMO I'd vote to just use display:none and leave the feature in.
|
|
Assignee | |
Comment 4•12 years ago
|
||
I don't think we should leave in code that isn't being used. If we ever wish to retrieve it, we're using a DCVS.
|
|
||
Updated•12 years ago
|
Attachment #694829 -
Flags: review?(bgirard) → review+
|
|
||
Comment 5•12 years ago
|
||
(In reply to Ed Morley [UTC+0; email:edmorley@moco] from comment #4) > I don't think we should leave in code that isn't being used. If we ever wish > to retrieve it, we're using a DCVS. In practice this doesn't always work as well. It causes merge conflicts and it's hard to remember what features are 'in the history'.
|
|
Assignee | |
Comment 6•12 years ago
|
||
https://hg.mozilla.org/build/tools/rev/71cece8e47df
|
|
Assignee | |
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
|
|
||
Updated•7 years ago
|
Component: Tools → General
You need to log in
before you can comment on or make changes to this bug.
Description
•