Closed Bug 823917 Opened 7 years ago Closed 7 years ago

Use C++11 final on MSVC11

Categories

(Core :: MFBT, defect)

All
Windows 8
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: emk, Assigned: emk)

References

()

Details

Attachments

(1 file)

MSVC11 supports C++11 final keyword.
They've supported equivalent functionality through a contextual "sealed" keyword since MSVC 2005.  Is this only about making MOZ_FINAL expand to final rather than sealed in new-enough MSVC?  I'm not complaining if you do that, but it doesn't seem to matter to me much, and if it were me I'd leave it all alone until every compiler we support supports the final contextual keyword.
After all, I wrote the patch with another cleanup.
|#if _MSC_VER >= 1400| is redundant because our minimum compiler requirement is MSVC 2005 (Or MFBT has a different requirement?).
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #695276 - Flags: review?(jwalden+bmo)
Try result (along with other patches):
https://tbpl.mozilla.org/?tree=Try&rev=ee97ff67d30b
Comment on attachment 695276 [details] [diff] [review]
Use C++11 final on MSVC11

Review of attachment 695276 [details] [diff] [review]:
-----------------------------------------------------------------

mfbt follows overall JS/Gecko compiler requirements (or at least there's been no reason not to follow them so far).  rs=me
Attachment #695276 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/001b109e68c4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.