823917 - Use C++11 final on MSVC11

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Masatoshi Kimura [:emk]]

MSVC11 supports C++11 final keyword.

Comment 1

[Jeff Walden [:Waldo]]

They've supported equivalent functionality through a contextual "sealed" keyword since MSVC 2005.  Is this only about making MOZ_FINAL expand to final rather than sealed in new-enough MSVC?  I'm not complaining if you do that, but it doesn't seem to matter to me much, and if it were me I'd leave it all alone until every compiler we support supports the final contextual keyword.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Use C++11 final on MSVC11

After all, I wrote the patch with another cleanup.
|#if _MSC_VER >= 1400| is redundant because our minimum compiler requirement is MSVC 2005 (Or MFBT has a different requirement?).

Comment 3

[Masatoshi Kimura [:emk]]

Try result (along with other patches):
https://tbpl.mozilla.org/?tree=Try&rev=ee97ff67d30b

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 695276 [details] [diff] [review]
Use C++11 final on MSVC11

Review of attachment 695276 [details] [diff] [review]:
-----------------------------------------------------------------

mfbt follows overall JS/Gecko compiler requirements (or at least there's been no reason not to follow them so far).  rs=me

Comment 5

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/001b109e68c4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/001b109e68c4