823932 - Change leaksoup to use nsAutoTArray rather than nsAutoVoidArray

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

nsVoidArray and friends are slowly being removed. leaksoup.cpp is the last use of nsAutoVoidArray, so once we clean that up, then we can remove nsAutoVoidArray.

The attached patch switches leaksoup.cpp to use nsAutoTArray.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 694845 [details] [diff] [review]
The fix

>-            while (stack.Count() > 0) {
>-                uint32_t pos = stack.Count() - 1;
>+            while (stack.Length() > 0) {
>+                uint32_t pos = stack.Length() - 1;
>                 AllocationNode *n =
>                     static_cast<AllocationNode*>(stack[pos]);

You can get rid of the cast here too.

r=dbaron

Thanks for fixing this.

Comment 2

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/96898e6b3078

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/96898e6b3078