824097 - Uninitialized memory read in nr_stun_server_ctx

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Eric Rescorla (:ekr)]

The offending code is here:


    if (clnt) {
        hmacPassword = &clnt->password;
    }
    else {
        hmacPassword = 0;
    }

However, hmacPassword is not used. This creates a UMR in valgrind but I do not believe has any security consequences. I marked it as "security" out of an abundance of caution.

Adam, Jesup if you agree this is safe, can you unhide it?

Comment 1

[Eric Rescorla (:ekr)]

Attachment: Remove UMR in nr_stun_server_send_response

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

I think a random-memory read (and no use of the value read) is not a security issue.

Comment 3

[Adam Roach [:abr]]

I see the cows are well out of the barn on this one, but I agree that there is no security issue here.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/495e435f86d9