824131 - [B2G][Wifi] Entering an incorrect password for a Wifi network does not give user a notification

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Cody Roesch [:croesch]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20100101 Firefox/17.0
Build ID: 20121128204232

Steps to reproduce:

1. Launch Build 20121217070202 version 18.0
2. Go into Settings
3. Go into Wifi
4. Tap on any secured wifi connection.
5. Enter a wrong password for the connection.
6. Notice there is no notification about entering a wrong password.

Repro: 100%


Actual results:

Once the incorrect password is entered, the connection is attempted but then the attempt fails and the list of networks refreshes and no notification is seen.


Expected results:

According to test case 3482:
User is notified that credentials are wrong.

Comment 1

[Cody Roesch [:croesch]]

Apparently there is another bug that was just written by another tester starting at the top of this suite working downward regarding hidden networks having this same issue. Understand this is probably a dupe.

Comment 2

[Nick Davidson]

Attachment: lodding to Wi-Fi with wrong Password

This is still repro on Test Run 2 - Unagi in Build 20130104070203 
Once the incorrect password is entered, OK button on upper right corner is pressed the connection is attempted for this particular network and "Connecting" string is displayed under the network you are trying to connect to for about 3-5sec but then password authentication fails and the list of networks refreshes and no notification is displayed.

Comment 3

[amiller]

UCID: set-018
https://moztrap.mozilla.org/results/case/62519/

Comment 4

[J Zimbrick]

Issue still occurs in Unagi build 20130115070201 with the December 5th Kernel.

Comment 5

[Jeni]

Build ID: 20130125070201
Kernel: Dec 5
Gecko:  http://hg.mozilla.org/releases/mozilla-b2g18/rev/94a2d6fcdfde
Gaia:   6369dbf33b622faf4b4d176fed30b77c5c319dfc

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Tracking, not a blocker.

Comment 7

[Darren]

The issue has been seen in build:
Build ID: 20130130070201
Kernel: Dec 5
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/4593f3e765eb
Gaia   f7f5a0cd17e3d04308cc5850b254947e127122b9

Comment 9

[Sam Shipley]

The issue where user is not notified that they have input the wrong credentials repros on the unagi device.

Updated to Unagi Build ID: 20130221070203
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/effe37a77f18
Gaia: bb633c6f2deb829b2f3d5b9e7bac7fa24467d02a

Comment 10

[Sam Shipley]

Issue reproduced on the unagi device during test run 5.1

Build ID: 20130225070200
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3a5a27992a75
Gaia: 5691a16fff8e1403c75ed9d6f3a443b7e58198c6

Comment 11

[Nick Davidson]

in reference to Comment 10

Test Case # 3482
UCID: set-018

https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=3482

Comment 12

[Nick Davidson]

(In reply to [e-mail] from comment #6)
> Tracking, not a blocker.

Issue still repro on Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/7508c5a1026b
Gaia: 7af427d35c4d557c75b2060022815f07851acc28

It might be a blocker If you will look from user stand point - user entered password for network, device showing -connection string  "connecting" and then available network list refreshes without (Big Fat Error message) user might think he is connected and will try to browse and do other things before he realize that he might of Fat-fingered network password... and not connected to any network...

Comment 13

[Vincent Chang[:vchang][changyihsin]]

The connection status will be updated to "connectingfailed" when WifiManager retry to establish the connection 3 times. It may takes several seconds. The gaia can get up to date status from gWifiManager.connection.status.

Comment 14

[Jeni]

Issue repros
Unagi Build ID: 20130417070205
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6bac24e14538
Gaia: 2d048a9bdae54e4ec7d48326c2130591c8b869b6

User is not notified about entering incorrect password

Comment 15

[:CSchmoeckel]

Issue remains open on Inari device. There is no "wrong password" message given when the user uses the incorrect WiFi password. 
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/54285d67454b
Gaia: c47ef39de04e634d847cc86b6acc616fabce69eb

Comment 16

[Jeni]

Issue repros on
Inari Build ID: 20130515070208
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/d06cfe7d67c2
Gaia: 0ddb515f15cbc6b74fc2742b7599d6ae74c6413f
 no notification saying you have used incorrect WiFi password

Comment 17

[sarsenyev]

The issue still reproduces on Leo device. No error messages appears. Just after 3 attempts, the device doesn't try to connect to a network 

Environmental  Variables:
Build ID: 20130610070206
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8e3f39363c54
Gaia: ce3b99781d182ad550a325206990c249b0dbcf0e
Platform Version: 18.0

Comment 18

[Cody Roesch [:croesch]]

Issue still reproduces on the following variables. Setting the need info flag to see if we can get some more traction on this.

Environmental Variables
Build ID: 20130802071207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/ba71c64705e5
Gaia: 361cfb69e22c0db18e85422bb407550426138009
Platform Version: 18.1
RIL Version: 01.01.00.019.171

Comment 19

[Evelyn Hung]

I'm not heavily working on Settings bug now, de-assign myself.

Comment 20

[Joshua Mitchell (Inactive)]

This also occurs on the 1.4 Open C
1.4 Environmental Variables:
Device: Open C 1.4 MOZ
BuildID: 20140428000206
Gaia: d23e479e8a4ce0bc620acb2d7e2f82801aa4d0ea
Gecko: 36f67ce46855
Version: 30.0a2
Firmware Version: P821A10-Eng_20140410

Comment 21

[Manuel Casas Barrado [:mancas]]

Attachment: WiFi bad credentials dialog

Comment 22

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8459435 [details] [review]
WiFi bad credentials dialog

The pull request seems incorrect?

Comment 23

[Jenny Lee]

(In reply to Manuel Casas Barrado [:mancas] from comment #21)
> Created attachment 8459435 [details] [review]
> WiFi bad credentials dialog

Hello Manuel, could you please attach the screenshot? I can't seem to access the file. Tks!

Comment 24

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8459435 [details] [review]
WiFi bad credentials dialog

>https://github.com/mozilla-b2g/gaia/pull/21979

Comment 25

[Manuel Casas Barrado [:mancas]]

Attachment: wifi-bad-credentials.png

Oh, sorry, the url was wrong. Now you can check the PR without any problems. Notice that the whole structure of WiFi files has changed so I had to modify my solution.

Thanks

Comment 26

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8459435 [details] [review]
WiFi bad credentials dialog

https://github.com/mozilla-b2g/gaia/pull/21979

Comment 27

[Manuel Casas Barrado [:mancas]]

Attachment: WiFi bad credentials dialog

Comment 28

[Jenny Lee]

Comment on attachment 8460063 [details]
wifi-bad-credentials.png

Looks good. Tks!
ni Matej to review the strings.

Comment 29

[Arthur Chen [:arthurcc][inactive after 6/30]]

I was told that the platform is not able to determine whether a connection failure is due to network problems (weak signal ...etc) or authentication problems. Which means we may not be able to display the dialog at a proper timing and with such specific text. I guess we can just notify users with a generic error message. Chuck, please let me know if I understand this correctly.

Comment 30

[Matej Novak [:matej]]

(In reply to Jenny Lee from comment #28)
> Comment on attachment 8460063 [details]
> wifi-bad-credentials.png
> 
> Looks good. Tks!
> ni Matej to review the strings.

Is the first part of that line necessary? Seems most important to let users know what went wrong and what they should do now, but maybe we don't need the technical explanation. I would suggest a small change to the header and then shorten the rest of the text:

Unable to connect to Wi-Fi
Please re-enter the network password.

Does that work?

Comment 31

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Yes, authentication fail doesn't 100% imply wrong password, especially on weak signal environment.
I think use general error message is better.

Also, wifi will try to connect other network automatically after current network failed, so user may see network is connected right after the error message. Or maybe multiple error message if user is in a very bad wifi environment.
I think it might be confusing and a little bit annoying(if I got the notification too many times)

I like to suggest
1. Show SSID in the notification.
2. Only show notification for first-time connecting network.(i.e., the network user connects to through inputs password UI flow)
3. Keep connection status in network list(UI shows "connecting failed" in network list now but usually being cleared by next event or list refresh)

Comment 32

[Manuel Casas Barrado [:mancas]]

(In reply to Chuck Lee [:chucklee] from comment #31)
> Yes, authentication fail doesn't 100% imply wrong password, especially on
> weak signal environment.
> I think use general error message is better.
> 
> Also, wifi will try to connect other network automatically after current
> network failed, so user may see network is connected right after the error
> message. Or maybe multiple error message if user is in a very bad wifi
> environment.
> I think it might be confusing and a little bit annoying(if I got the
> notification too many times)
> 
> I like to suggest
> 1. Show SSID in the notification.
> 2. Only show notification for first-time connecting network.(i.e., the
> network user connects to through inputs password UI flow)
> 3. Keep connection status in network list(UI shows "connecting failed" in
> network list now but usually being cleared by next event or list refresh)

So our goal now is to show the SSID in the dialog, only show the dialog after enter network password and keep the fail status in the UI, isn't it?

I've a question about the second point, after trying to connect to the new network, the dialog would be shown so...if user select "re-enter password", must the dialog appear again, if the connection fail?

Comment 33

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

(In reply to Manuel Casas Barrado [:mancas] from comment #32)
> So our goal now is to show the SSID in the dialog, only show the dialog
> after enter network password and keep the fail status in the UI, isn't it?
> 
> I've a question about the second point, after trying to connect to the new
> network, the dialog would be shown so...if user select "re-enter password",
> must the dialog appear again, if the connection fail?

Yes, AFAIK, Gaia handles "re-enter password" as same as "enter password for the first time" now.

Is pressing "OK" in the dialog means "re-enter password" and will bring up the enter password dialog automatically?

Comment 34

[Manuel Casas Barrado [:mancas]]

(In reply to Chuck Lee [:chucklee] from comment #33)
> (In reply to Manuel Casas Barrado [:mancas] from comment #32)
> > So our goal now is to show the SSID in the dialog, only show the dialog
> > after enter network password and keep the fail status in the UI, isn't it?
> > 
> > I've a question about the second point, after trying to connect to the new
> > network, the dialog would be shown so...if user select "re-enter password",
> > must the dialog appear again, if the connection fail?
> 
> Yes, AFAIK, Gaia handles "re-enter password" as same as "enter password for
> the first time" now.
> 
> Is pressing "OK" in the dialog means "re-enter password" and will bring up
> the enter password dialog automatically?

Yes, after pressing "OK" button, the dialog is shown again. So if the device can't connect to the network, the dialog will be show so many times.

One solution could be showing the dialog twice and after that, let the user to touch again the network to enter the password. What's your thought?

Comment 35

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

If user is expecting a dialog while connection fail after entering password, wouldn't missing the dialog make user think the connection is succeeded?
Since we have the cancel button in the dialog, I prefer always show the dialog if user choose the re-enter the password.

On the other hand, because gecko will try to connect to other known networks(networks has been successfully connected before) and the retry might also fail(but doesn't need to show dialog), it might be difficult for Gaia to count connection failures because the incoming event could be
"connection fail to network A"
(user is re-entering password for network A)
-> "connection fail to network B"(known network, poor signal)
-> "connection success to network C"(known network)
(user completes entering password)
-> "connection fail to network A"

Comment 36

[Manuel Casas Barrado [:mancas]]

Now the SSID is showed in the dialog and it's only show when the user type the password. However, UI does not show "connection failed" because after this event, the UI is automatically refresh and immediately wifiManager try to connect to a different available network

Comment 37

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

I am not familiar with details about settings app, maybe Gaia can mark connection failed these network for showing in network list.
Since we can't keep the status now, I think we can improve this in another follow up bug.

Comment 38

[Manuel Casas Barrado [:mancas]]

(In reply to Chuck Lee [:chucklee] from comment #37)
> I am not familiar with details about settings app, maybe Gaia can mark
> connection failed these network for showing in network list.
> Since we can't keep the status now, I think we can improve this in another
> follow up bug.

So let's wait for arthur review.

Comment 39

[Arthur Chen [:arthurcc][inactive after 6/30]]

Sorry for the delay. I'll review this later as I have got some urgent tasks.

Comment 40

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8460148 [details] [review]
WiFi bad credentials dialog

Please check my comments in github, thanks!

Comment 41

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8460148 [details] [review]
WiFi bad credentials dialog

Hey Arthur! Take a look at the commit. Thanks!

Comment 42

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8460148 [details] [review]
WiFi bad credentials dialog

We are almost there, please check my comments in github regarding dispatching the event. Thanks!

Comment 43

[Manuel Casas Barrado [:mancas]]

Please check the new commit. Thanks!

Comment 44

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8460148 [details] [review]
WiFi bad credentials dialog

The patch looks good to me, but I rarely see the wifi status becomes "connectingfailed". I think we may have gecko issue here. Let's land the gaia patch first and track the gecko issue with another bug, thanks!

Comment 45

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/04bfb7cab6a5485b650dac75cf99b8509ae148fc

Comment 46

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8460148 [details] [review]
WiFi bad credentials dialog

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 47

[Manuel Casas Barrado [:mancas]]

(In reply to Manuel Casas Barrado [:mancas] from comment #46)
> Comment on attachment 8460148 [details] [review]
> WiFi bad credentials dialog
> 
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #):
> [User impact] if declined: Low
> [Testing completed]: No
> [Risk to taking this patch] (and alternatives if risky): Low
> [String changes made]: Yes

Comment 48

[Manuel Casas Barrado [:mancas]]

(In reply to Manuel Casas Barrado [:mancas] from comment #47)
> (In reply to Manuel Casas Barrado [:mancas] from comment #46)
> > Comment on attachment 8460148 [details] [review]
> > WiFi bad credentials dialog
> > 
> > [Approval Request Comment]
> > [Bug caused by] (feature/regressing bug #):
> > [User impact] if declined: Hight
> > [Testing completed]: No
> > [Risk to taking this patch] (and alternatives if risky): Low
> > [String changes made]: Yes

Comment 49

[[:fabrice] Fabrice Desré]

What do you mean by "no testing completed"? We don't have automated tests, and no manual smoketests either?

Comment 50

[Manuel Casas Barrado [:mancas]]

Yes, we don't have unit or integration test to check this prompt. Let's track a new bug to make tests for this part and then we will request approval again

Comment 51

[Maria Angeles Oteo (:oteo)]

Follow up bug created to add the integration tests: Bug 1064156

Comment 52

[bhavana bajaj [:bajaj]]

Comment on attachment 8460148 [details] [review]
WiFi bad credentials dialog

Thanks for adding the tests 1064156, feel free to uplift those as needed. approving this now given its close to l10n deadline.

Comment 53

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/10c6e19de5998fde87315840ac37f3f12da6a4a6

Comment 54

[Sue]

Attachment: video of issue verify

This issue has been verified successfully on Flame v2.1 & v2.2
STR:
1. Launch Settings -> Wi-Fi.
2. Select a secured wifi connection.(like B-2-6)
3. Enter a wrong password for the connection.
**After 4th connection, it will remind "Unable to connect to B-2-6, authentication failed due to bad credentials. Please re-enter the network password."
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        5372b675e018b6aac97d95ff5db8d4bd16addb9b
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f34377ae402b
Build-ID        20141127001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141127.035005
FW-Date         Thu Nov 27 03:50:16 EST 2014
Bootloader      L1TC00011880

Flame 2.2 versions:
Gaia-Rev        80bc1445959db79e9d2e947cc56e1eb7b0d3d0f0
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/7dfad34d265b
Build-ID        20141127040204
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141127.074535
FW-Date         Thu Nov 27 07:45:46 EST 2014
Bootloader      L1TC00011880