824140 - out-of-order init list in Netd.cpp

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning:
{
ipc/netd/Netd.h: In constructor 'mozilla::ipc::NetdClient::NetdClient()':
ipc/netd/Netd.h:62: warning: 'mozilla::ipc::NetdClient::mSocket' will be initialized after
ipc/netd/Netd.h:59: warning:   'MessageLoopForIO* mozilla::ipc::NetdClient::mIOLoop'
ipc/netd/Netd.cpp:87: warning:   when initialized here
}
Bug 805478 added mSocket there; it just added it at the wrong point in the list.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

This makes the init-list ordering match the order in the .h file.

Here's the relevant chunk of the .h file, for reference:
 https://mxr.mozilla.org/mozilla-central/source/ipc/netd/Netd.h?mark=59-66#59

Comment 2

[StevenLee[:slee]]

Comment on attachment 695033 [details] [diff] [review]
fix

Review of attachment 695033 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good.

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/757482ef1bfb

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/757482ef1bfb