Closed Bug 824140 Opened 7 years ago Closed 7 years ago

out-of-order init list in Netd.cpp

Categories

(Core :: IPC, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Build warning:
{
ipc/netd/Netd.h: In constructor 'mozilla::ipc::NetdClient::NetdClient()':
ipc/netd/Netd.h:62: warning: 'mozilla::ipc::NetdClient::mSocket' will be initialized after
ipc/netd/Netd.h:59: warning:   'MessageLoopForIO* mozilla::ipc::NetdClient::mIOLoop'
ipc/netd/Netd.cpp:87: warning:   when initialized here
}
Bug 805478 added mSocket there; it just added it at the wrong point in the list.
Attached patch fixSplinter Review
This makes the init-list ordering match the order in the .h file.

Here's the relevant chunk of the .h file, for reference:
 https://mxr.mozilla.org/mozilla-central/source/ipc/netd/Netd.h?mark=59-66#59
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #695033 - Flags: review?(slee)
Comment on attachment 695033 [details] [diff] [review]
fix

Review of attachment 695033 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good.
Attachment #695033 - Flags: review?(slee) → review+
https://hg.mozilla.org/mozilla-central/rev/757482ef1bfb
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.