Closed
Bug 824230
Opened 12 years ago
Closed 12 years ago
Don't keep asking decoders to read audio and video after a (likely OOM) error has occurred
Categories
(Core :: Audio/Video, defect)
Tracking
()
People
(Reporter: cjones, Assigned: cjones)
References
Details
Attachments
(1 file)
|
1.53 KB,
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
STR
(1) Modify libstagefright OMXDecoder.cpp's read() to always return UNKNOWN_ERROR
(2) Load an mp4 resource onto sdcard
This simulates OOM conditions with some decoders, and is also an error we should handle regardless. Patch forthcoming.
|
Assignee | |
Comment 1•12 years ago
|
||
The null check in OmxDecoder::ReadAudio looks a bit spotty, but I'm not sure where that logic is supposed to go.
This is an || review request. Hope you guys enjoy your holidays :).
Assignee: nobody → jones.chris.g
Attachment #695156 -
Flags: review?(cpearce)
Attachment #695156 -
Flags: review?(chris.double)
|
||
Updated•12 years ago
|
Attachment #695156 -
Flags: review?(cpearce)
Attachment #695156 -
Flags: review?(chris.double)
Attachment #695156 -
Flags: review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Blocks a blocker.
blocking-basecamp: --- → +
Target Milestone: --- → B2G C3 (12dec-1jan)
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•12 years ago
|
||
|
||
Comment 8•12 years ago
|
||
FYI - this patch broke AAC playback in web content on b2g. See bug 825485 for a followup.
You need to log in
before you can comment on or make changes to this bug.
Description
•