Don't keep asking decoders to read audio and video after a (likely OOM) error has occurred

RESOLVED FIXED in Firefox 19

Status

()

Core
Audio/Video
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: cjones, Assigned: cjones)

Tracking

Trunk
B2G C3 (12dec-1jan)
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(blocking-basecamp:+, firefox19 fixed, firefox20 fixed, b2g18 fixed)

Details

Attachments

(1 attachment)

STR
 (1) Modify libstagefright OMXDecoder.cpp's read() to always return UNKNOWN_ERROR
 (2) Load an mp4 resource onto sdcard

This simulates OOM conditions with some decoders, and is also an error we should handle regardless.  Patch forthcoming.
Created attachment 695156 [details] [diff] [review]
Handle UNKNOWN_ERROR in OmxDecoder

The null check in OmxDecoder::ReadAudio looks a bit spotty, but I'm not sure where that logic is supposed to go.

This is an || review request.  Hope you guys enjoy your holidays :).
Assignee: nobody → jones.chris.g
Attachment #695156 - Flags: review?(cpearce)
Attachment #695156 - Flags: review?(chris.double)

Updated

6 years ago
Attachment #695156 - Flags: review?(cpearce)
Attachment #695156 - Flags: review?(chris.double)
Attachment #695156 - Flags: review+
Blocks a blocker.
blocking-basecamp: --- → +
Target Milestone: --- → B2G C3 (12dec-1jan)
Duplicate of this bug: 821082
https://hg.mozilla.org/mozilla-central/rev/14f59c9396d3
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/releases/mozilla-aurora/rev/86d252d055a2
https://hg.mozilla.org/releases/mozilla-b2g18/rev/c30b2a994cb6
status-b2g18: --- → fixed
status-firefox19: --- → fixed
status-firefox20: --- → fixed
Duplicate of this bug: 824224
FYI - this patch broke AAC playback in web content on b2g. See bug 825485 for a followup.

Updated

5 years ago
Depends on: 825485
You need to log in before you can comment on or make changes to this bug.