Closed Bug 824230 Opened 7 years ago Closed 7 years ago

Don't keep asking decoders to read audio and video after a (likely OOM) error has occurred

Categories

(Core :: Audio/Video, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
B2G C3 (12dec-1jan)
blocking-basecamp +
Tracking Status
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed

People

(Reporter: cjones, Assigned: cjones)

References

Details

Attachments

(1 file)

STR
 (1) Modify libstagefright OMXDecoder.cpp's read() to always return UNKNOWN_ERROR
 (2) Load an mp4 resource onto sdcard

This simulates OOM conditions with some decoders, and is also an error we should handle regardless.  Patch forthcoming.
The null check in OmxDecoder::ReadAudio looks a bit spotty, but I'm not sure where that logic is supposed to go.

This is an || review request.  Hope you guys enjoy your holidays :).
Assignee: nobody → jones.chris.g
Attachment #695156 - Flags: review?(cpearce)
Attachment #695156 - Flags: review?(chris.double)
Attachment #695156 - Flags: review?(cpearce)
Attachment #695156 - Flags: review?(chris.double)
Attachment #695156 - Flags: review+
Blocks a blocker.
blocking-basecamp: --- → +
Target Milestone: --- → B2G C3 (12dec-1jan)
Duplicate of this bug: 821082
https://hg.mozilla.org/mozilla-central/rev/14f59c9396d3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Duplicate of this bug: 824224
FYI - this patch broke AAC playback in web content on b2g. See bug 825485 for a followup.
Depends on: 825485
You need to log in before you can comment on or make changes to this bug.