Closed
Bug 824244
Opened 12 years ago
Closed 8 years ago
Merge nsDiskCacheBinding and nsDiskCacheStream: less code, less objects, less risk
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: alfredkayser, Assigned: alfredkayser)
References
Details
(Keywords: memory-footprint, perf)
Attachments
(1 file, 1 obsolete file)
|
31.19 KB,
patch
|
Details | Diff | Splinter Review |
Like bug 405407, the nsDiskCacheBinding object always has a nsDiskCacheStreamIO object. Combining these reduces memory fragmentation, reduces code and removes risky pointers.
|
Assignee | |
Updated•12 years ago
|
|
|
Assignee | |
Updated•12 years ago
|
Attachment #695175 -
Attachment is patch: true
|
|
Assignee | |
Comment 1•11 years ago
|
||
In this patch I kept the methods in nsDiskCacheStream.cpp even if moved to the nsDiskCacheBinding class, so show the real differences in code.
Attachment #695175 -
Attachment is obsolete: true
|
||
Comment 2•11 years ago
|
||
Is this bug INVALID as bug #405407 was fixed?
|
|
Assignee | |
Comment 3•11 years ago
|
||
No, that one was about merging nsDiskCacheStreamIO and nsDiskCacheStreamOutput. This is about merging that merged object into nsDiskCacheBinding.
|
||
Comment 4•8 years ago
|
||
new cache code now
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•