Closed Bug 824312 Opened 7 years ago Closed 7 years ago

Remove JS version gunk

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: emk, Assigned: emk)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

JSVERSION_1_0 to JSVERSION_1_5 (modulo JSVERSION_ECMA_3) have no differences from JSVERSION_DEFAULT anymore, and they are unlikely to have in future. All language extensions available under JSVERSION_DEFAULT are also available under those versions.
It just confuse readers. (At least I'm a bit little confused.)
Assignee: general → VYV03354
Status: NEW → ASSIGNED
Attachment #695275 - Flags: review?(jwalden+bmo)
Comment on attachment 695275 [details] [diff] [review]
Drop support for JSVersion <= 1.5

Review of attachment 695275 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi-tests/testVersion.cpp
@@ +23,5 @@
>  JSBool CheckVersionHasMoarXML(JSContext *cx, unsigned argc, jsval *vp);
>  JSBool DisableMoarXMLOption(JSContext *cx, unsigned argc, jsval *vp);
>  JSBool CallSetVersion17(JSContext *cx, unsigned argc, jsval *vp);
>  JSBool CheckNewScriptNoXML(JSContext *cx, unsigned argc, jsval *vp);
> +JSBool OverrideVersionDefault(JSContext *cx, unsigned argc, jsval *vp);

jorendorff thinks this should be changed not to Default, but to some other JS version now that 1.5's going away.  How about make this OverrideVersion18, and use JSVERSION_1_8 through here as appropriate?
Attachment #695275 - Flags: review?(jwalden+bmo) → review+
...oh, and you should update that wiki page, since you're making the change here.  :-)  There are {{obsolete_*(20)}} or whatever markers you can use to do it -- see examples on the main JSAPI reference page.
Fixed the review comment and pushed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5e54ecc1601
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/c5e54ecc1601
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.