824312 - Remove JS version gunk

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Masatoshi Kimura [:emk]]

JSVERSION_1_0 to JSVERSION_1_5 (modulo JSVERSION_ECMA_3) have no differences from JSVERSION_DEFAULT anymore, and they are unlikely to have in future. All language extensions available under JSVERSION_DEFAULT are also available under those versions.
It just confuse readers. (At least I'm a bit little confused.)

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Drop support for JSVersion <= 1.5

Comment 2

[Masatoshi Kimura [:emk]]

Green on try:
https://tbpl.mozilla.org/?tree=Try&rev=ee97ff67d30b

Comment 3

[Masatoshi Kimura [:emk]]

https://developer.mozilla.org/en-US/docs/SpiderMonkey/JSAPI_Reference/JSVersion should be updated.

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 695275 [details] [diff] [review]
Drop support for JSVersion <= 1.5

Review of attachment 695275 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi-tests/testVersion.cpp
@@ +23,5 @@
>  JSBool CheckVersionHasMoarXML(JSContext *cx, unsigned argc, jsval *vp);
>  JSBool DisableMoarXMLOption(JSContext *cx, unsigned argc, jsval *vp);
>  JSBool CallSetVersion17(JSContext *cx, unsigned argc, jsval *vp);
>  JSBool CheckNewScriptNoXML(JSContext *cx, unsigned argc, jsval *vp);
> +JSBool OverrideVersionDefault(JSContext *cx, unsigned argc, jsval *vp);

jorendorff thinks this should be changed not to Default, but to some other JS version now that 1.5's going away.  How about make this OverrideVersion18, and use JSVERSION_1_8 through here as appropriate?

Comment 5

[Jeff Walden [:Waldo]]

...oh, and you should update that wiki page, since you're making the change here.  :-)  There are {{obsolete_*(20)}} or whatever markers you can use to do it -- see examples on the main JSAPI reference page.

Comment 6

[Masatoshi Kimura [:emk]]

Fixed the review comment and pushed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5e54ecc1601

Comment 7

[Masatoshi Kimura [:emk]]

Updated the doc.
https://developer.mozilla.org/en-US/docs/SpiderMonkey/JSAPI_Reference/JSVersion

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c5e54ecc1601