Closed
Bug 824344
Opened 13 years ago
Closed 13 years ago
Port |Bug 804834 - Part 1: Fix tests depending on E4X for-each in content JS| [feed_discovery.html mochitest-5 permaorange]
Categories
(SeaMonkey :: Feed Discovery and Preview, defect)
SeaMonkey
Feed Discovery and Preview
Tracking
(Not tracked)
VERIFIED
FIXED
seamonkey2.17
People
(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)
Details
Attachments
(1 file)
|
1.43 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
"for each" with "in" is not available to content scripts anymore since bug 804834 landed. Example fallout from this:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1356215401.1356216858.30908.gz
s: sea-vm-win32-4
JavaScript error: http://mochi.test:8888/tests/suite/browser/test/feed_discovery.html, line 91: missing ( after for
3837 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_feed_discovery.html | Test timed out.
Original changeset: http://hg.mozilla.org/mozilla-central/rev/b0f89c4fb6dd
I'm not 100% sure that feed_discovery.html is the only place we need to fix. Kindly check.
Attachment #695303 -
Flags: review?(neil)
Attachment #695303 -
Flags: feedback?(philip.chee)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 695303 [details] [diff] [review]
patch [Checkin: Comment 2]
Seems reasonable.
(This is the only suite html test containing for each.)
Attachment #695303 -
Flags: review?(neil) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 695303 [details] [diff] [review]
patch [Checkin: Comment 2]
http://hg.mozilla.org/comm-central/rev/860d2e79888d
Attachment #695303 -
Attachment description: patch → patch [Checkin: Comment 2]
Attachment #695303 -
Flags: feedback?(philip.chee)
|
|
Assignee | |
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.17
|
|
Assignee | |
Comment 3•13 years ago
|
||
mochitest-5, actually. Verified:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1356342241.1356342957.20267.gz
Status: RESOLVED → VERIFIED
Summary: Port |Bug 804834 - Part 1: Fix tests depending on E4X for-each in content JS| [feed_discovery.html mochitest-4 permaorange] → Port |Bug 804834 - Part 1: Fix tests depending on E4X for-each in content JS| [feed_discovery.html mochitest-5 permaorange]
You need to log in
before you can comment on or make changes to this bug.
Description
•