824397 - Use NS_ENSURE_TRUE_VOID(foo) instead of NS_ENSURE_TRUE(foo, )

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Nicholas Nethercote [inactive]]

I just updated my Ubuntu installation to 12.10 and got a new clang, and now I'm getting failures like these:

  /home/njn/moz/mi2/content/media/webm/WebMReader.cpp:1033:74: error: empty macro arguments are a C99 feature [-Werror,-Wc99-extensions]
  NS_ENSURE_TRUE((uint32_t)aSubsegmentIdx < mClusterByteRanges.Length(), );
 
They're errors in some dirs and warnings in others, so there must be some WARNINGS_AS_ERRORS action happening.  (I'm compiling with --enable-warnings-as-errors.)

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Use NS_ENSURE_{TRUE,FALSE,SUCCESS}_VOID(foo) instead of NS_ENSURE_{TRUE,FALSE,SUCCESS}(foo, ).

Simple patch.

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 695375 [details] [diff] [review]
Use NS_ENSURE_{TRUE,FALSE,SUCCESS}_VOID(foo) instead of NS_ENSURE_{TRUE,FALSE,SUCCESS}(foo, ).

This patch misses some that use /**/ (or varations) as the 2nd arg.  I'll post a new version shortly.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Use NS_ENSURE_{TRUE,FALSE,SUCCESS}_VOID(foo) instead of NS_ENSURE_{TRUE,FALSE,SUCCESS}(foo, ).

New version that converts the NS_ENSURE_TRUE(foo, /**/) cases too.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/372d779d8f27

Comment 5

[(PTO May 7-12) Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/372d779d8f27