Closed
Bug 824463
Opened 13 years ago
Closed 13 years ago
IonMonkey: ARM: Fix checkStackAlignment
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
660 bytes,
patch
|
mjrosenb
:
review+
|
Details | Diff | Splinter Review |
Condition should be NotEqual/NonZero instead of Equal. This broke almost all jit-tests on ARM; too bad TBPL doesn't run any tests with ARM debug builds.
Attachment #695457 -
Flags: review?(mrosenberg)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 695457 [details] [diff] [review]
Patch
Review of attachment 695457 [details] [diff] [review]:
-----------------------------------------------------------------
I've had this patch floating around for a while, but evidently, the current code worked when nrc tested it, so I've been meaning to figure out exactly why that was happening before landing it. Since it is actively getting in people's ways, go for it.
Attachment #695457 -
Flags: review?(mrosenberg) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
|
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•