82448 - Install display appears to show negative disk space

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[(not reading, please use [e-mail] instead)]

I have 5 gigs free, installer tells me I have -5 gigs

a screen shot says it best.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 2

[Sean Su]

actually, I believe that's part of the formatting.  notice that there's a space 
between the '-' and the first digit.

I think we need a UE person's input on this.

Comment 3

[Henrik Gemal]

Who should have a say on this one?

Comment 4

[Håkan Waara]

I saw this today when I used the installer [for the first time, btw].

This looks really strange, please remove the dash.

Gemal: I don't believe any UI people actually have to OK this, since it's an
obvious error.

Comment 5

[doctor__j]

*** Bug 84604 has been marked as a duplicate of this bug. ***

Comment 6

[Sean Su]

over to Curt.  Should be a simple fix if the only thing is to remove the '-'.

Comment 7

[Alfonso Martinez]

*** Bug 132966 has been marked as a duplicate of this bug. ***

Comment 8

[Henrik Gemal]

*** Bug 137981 has been marked as a duplicate of this bug. ***

Comment 9

[Daniel Veditz [:dveditz]]

Nominating this trivial fix. Deleting the hyphen separator will avoid confusing
people.

Comment 10

[Bart van Bragt]

Confirmed in RC1.

Could someone please fix this before the release? Thanks.

Comment 11

[Henrik Gemal]

*** Bug 150392 has been marked as a duplicate of this bug. ***

Comment 12

[Daniel Veditz [:dveditz]]

This is easy, and the formatting confuses people who are paying attention. I
realize that's a small fraction of people who install, but we shouldn't
discourage that behavior.

Comment 13

[Daniel Veditz [:dveditz]]

The problem is on lines 1036 and 1240 of dialogs.c

Comment 14

[Curt Patrick (gone)]

Attachment: Patch 1

Comment 15

[timeless]

do we still need 3 spaces?

Comment 16

[Håkan Waara]

Only one space is needed, as far as I can see.

Comment 17

[Curt Patrick (gone)]

At first I did 2 spaces, which is commonly what follows a colon.  But then I
figured that the less change the better.  Just replacing the dash with a space
is a small a change as it gets.  And I liked the look of having some seperation
between the drive letter and the numbers.  But I've got no terribly strong
preference if you really think it should just be a single space.  What is the
concensus?

Comment 18

[dprice (gone)]

Comment on attachment 88319 [details] [diff] [review]
Patch 1

r=dprice

Replacing the '-' with a ' ' is fine with me.  Nothing will move in the dialog

Comment 19

[Håkan Waara]

as long as it doesn't look weird with three spaces until the next word in that
sentence...

Comment 20

[Daniel Veditz [:dveditz]]

Comment on attachment 88319 [details] [diff] [review]
Patch 1

sr=dveditz

Comment 21

[Curt Patrick (gone)]

Checked into trunk.  Need drivers approval and adt plussed to check into branch.

Comment 22

[Curt Patrick (gone)]

I guess I should have marked this fixed when I checked it into the trunk.

Comment 23

[Jaime Rodriguez, Jr.]

adt1.0.1 (on ADT's behalf) approval for checkin to the 1.0 branch, pending
drivers' approval. pls check this in asap, then add the "fixed1.0.1" keyword.

Comment 24

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 25

[Curt Patrick (gone)]

Checked into mozilla branch.

Comment 26

[Grace Bush]

trunk 2002070204
branch 2002070208