Beginning on October 25th, 2016, Persona will no longer be an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 824483 - [Tablet] - Regression: about:home thumbnails are cut off; missing promo banner in landscape orientation
: [Tablet] - Regression: about:home thumbnails are cut off; missing promo banne...
: regression, reproducible
Product: Firefox for Android
Classification: Client Software
Component: General (show other bugs)
: unspecified
: ARM Android
: -- normal (vote)
: Firefox 21
Assigned To: Sriram Ramasubramanian [:sriram]
: Sebastian Kaspari (:sebastian)
: 830442 839482 (view as bug list)
Depends on:
  Show dependency treegraph
Reported: 2012-12-24 08:26 PST by Aaron Train [:aaronmt]
Modified: 2016-07-29 14:31 PDT (History)
15 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Nightly (12/24) - Screenshot (201.21 KB, image/png)
2012-12-24 08:26 PST, Aaron Train [:aaronmt]
no flags Details
Nightly (12/24) - Screenshot (Portrait) (306.31 KB, image/png)
2012-12-24 08:27 PST, Aaron Train [:aaronmt]
no flags Details
screenshot on Xoom with tab sidebar (391.37 KB, image/png)
2013-01-10 17:27 PST, Matt Brubeck (:mbrubeck)
no flags Details
Patch (1.32 KB, patch)
2013-02-12 15:24 PST, Sriram Ramasubramanian [:sriram]
wjohnston2000: review+
lukasblakk+bugs: approval‑mozilla‑aurora+
lukasblakk+bugs: approval‑mozilla‑beta-
Details | Diff | Splinter Review

Description Aaron Train [:aaronmt] 2012-12-24 08:26:03 PST
Created attachment 695488 [details]
Nightly (12/24) - Screenshot

See screenshot

Nightly (12/24)
Asus Transformer Prime TF201 (Android 4.0.4)
Comment 1 Aaron Train [:aaronmt] 2012-12-24 08:27:20 PST
Created attachment 695489 [details]
Nightly (12/24) - Screenshot (Portrait)

Portrait is fine; landscape issue.
Comment 2 Wesley Johnston (:wesj) 2012-12-28 17:12:18 PST
Hmm.. I can't repro this on my Galaxy Tab 10.1. Are you doing anything fancy? Starting in portrait then switching to landscape, or vice versa?
Comment 3 Catalin Suciu [:csuciu] 2013-01-08 03:24:16 PST
I cannot reproduce on Asus Transformer EEE (Android 4.0.4) using Nightly 20.0a1 (2013-01-07)
Comment 4 Matt Brubeck (:mbrubeck) 2013-01-10 17:27:57 PST
Created attachment 700788 [details]
screenshot on Xoom with tab sidebar

I can reproduce this intermittently on my Motorola Xoom Wi-Fi (Android 4.1).  I also frequently get a layout like this attachment, where the marketplace promo banner is weirdly squashed.  This variant happens only when the tab sidebar is visible.  Or sometimes the tabs are not cut off (or barely cut off) but the marketplace banner is completely gone.

As far as I can tell, Firefox 18 Beta is not affected, but Firefox 19 Aurora is.
Comment 5 Aaron Train [:aaronmt] 2013-01-14 17:41:44 PST
*** Bug 830442 has been marked as a duplicate of this bug. ***
Comment 6 Aaron Train [:aaronmt] 2013-01-14 17:42:17 PST
Brad ran into this too in the dupe above.
Comment 7 Aaron Train [:aaronmt] 2013-01-31 11:36:22 PST

Rotate from portait to landscape
Comment 8 Aaron Train [:aaronmt] 2013-02-08 07:20:28 PST
*** Bug 839482 has been marked as a duplicate of this bug. ***
Comment 9 Aaron Train [:aaronmt] 2013-02-08 07:22:21 PST
This is now
Comment 10 Aaron Train [:aaronmt] 2013-02-08 07:22:47 PST
(too late for 19 I think)
Comment 11 Aaron Train [:aaronmt] 2013-02-11 14:12:38 PST
Steps for the TF201

i) Open Fennec in landscape
Comment 12 Sriram Ramasubramanian [:sriram] 2013-02-12 14:07:55 PST
Is there a regression range?
Comment 13 Sriram Ramasubramanian [:sriram] 2013-02-12 15:24:28 PST
Created attachment 713149 [details] [diff] [review]

There's a condition to try and return the attribute "columnWidth" 's value if its running a version above 16. However, no attribute is specified in XML. Hence the value will be 0dp, this will cause the height to be shrunk while calculating the heightMeasureSpec.
Comment 14 Wesley Johnston (:wesj) 2013-02-12 15:28:39 PST
Comment on attachment 713149 [details] [diff] [review]

Review of attachment 713149 [details] [diff] [review]:

::: mobile/android/base/
@@ +789,5 @@
>              return getColumnWidth(getWidth());
>          }
>          public int getColumnWidth(int width) {
> +            return (width - getPaddingLeft() - getPaddingRight()) / mNumberOfCols;

Cool. Can you add a note that super.getColumnWidth() doesn't always return the correct thing on all devices (because it seems to work on everything I have that's 16+).
Comment 15 Sriram Ramasubramanian [:sriram] 2013-02-12 15:32:32 PST
Comment 16 Sriram Ramasubramanian [:sriram] 2013-02-12 15:34:05 PST
Comment on attachment 713149 [details] [diff] [review]

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Old code with a check for 16.
User impact if declined: Thumbnails will be cut off.
Testing completed (on m-c, etc.): Landed on m-i just now.
Risk to taking this patch (and alternatives if risky): None. The "else" part works everywhere else and been tested a lot. Now we are making it the default.
String or UUID changes made by this patch: None.
Comment 17 Ryan VanderMeulen [:RyanVM] 2013-02-13 07:29:09 PST
Comment 18 Lukas Blakk [:lsblakk] use ?needinfo 2013-02-13 12:13:42 PST
Comment on attachment 713149 [details] [diff] [review]

We're not taking any new changes on beta at this point since we're about to release and this is not a release-blocking issue so only approving for Aurora.
Comment 19 Sriram Ramasubramanian [:sriram] 2013-02-14 09:56:07 PST
Comment 20 Aaron Train [:aaronmt] 2013-02-14 12:38:21 PST
Quite a visible known-issue on tablets; rel-note for 19?
Comment 21 Aaron Train [:aaronmt] 2013-02-14 12:38:43 PST

Note You need to log in before you can comment on or make changes to this bug.