Closed Bug 824483 Opened 8 years ago Closed 8 years ago

[Tablet] - Regression: about:home thumbnails are cut off; missing promo banner in landscape orientation

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox18 unaffected, firefox19 affected, firefox20 verified, firefox21 verified, relnote-firefox +, fennec19+)

VERIFIED FIXED
Firefox 21
Tracking Status
firefox18 --- unaffected
firefox19 --- affected
firefox20 --- verified
firefox21 --- verified
relnote-firefox --- +
fennec 19+ ---

People

(Reporter: aaronmt, Assigned: sriram)

References

Details

(Keywords: regression, reproducible)

Attachments

(4 files)

See screenshot

---
Nightly (12/24)
Asus Transformer Prime TF201 (Android 4.0.4)
Portrait is fine; landscape issue.
Summary: [Tablet] - Regression: about:home thumbnails are cut off; missing promo banner → [Tablet] - Regression: about:home thumbnails are cut off; missing promo banner in landscape orientation
Assignee: nobody → lucasr.at.mozilla
tracking-fennec: ? → 20+
Hmm.. I can't repro this on my Galaxy Tab 10.1. Are you doing anything fancy? Starting in portrait then switching to landscape, or vice versa?
I cannot reproduce on Asus Transformer EEE (Android 4.0.4) using Nightly 20.0a1 (2013-01-07)
I can reproduce this intermittently on my Motorola Xoom Wi-Fi (Android 4.1).  I also frequently get a layout like this attachment, where the marketplace promo banner is weirdly squashed.  This variant happens only when the tab sidebar is visible.  Or sometimes the tabs are not cut off (or barely cut off) but the marketplace banner is completely gone.

As far as I can tell, Firefox 18 Beta is not affected, but Firefox 19 Aurora is.
Attachment #700788 - Attachment is patch: false
Attachment #700788 - Attachment mime type: text/plain → image/png
tracking-fennec: 20+ → 19+
Duplicate of this bug: 830442
Brad ran into this too in the dupe above.
STR:

Rotate from portait to landscape
Assignee: lucasr.at.mozilla → sriram
Duplicate of this bug: 839482
This is now
(too late for 19 I think)
Steps for the TF201

i) Open Fennec in landscape
Is there a regression range?
Attached patch PatchSplinter Review
There's a condition to try and return the attribute "columnWidth" 's value if its running a version above 16. However, no attribute is specified in XML. Hence the value will be 0dp, this will cause the height to be shrunk while calculating the heightMeasureSpec.
Attachment #713149 - Flags: review?(wjohnston)
Comment on attachment 713149 [details] [diff] [review]
Patch

Review of attachment 713149 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/AboutHomeContent.java
@@ +789,5 @@
>              return getColumnWidth(getWidth());
>          }
>  
>          public int getColumnWidth(int width) {
> +            return (width - getPaddingLeft() - getPaddingRight()) / mNumberOfCols;

Cool. Can you add a note that super.getColumnWidth() doesn't always return the correct thing on all devices (because it seems to work on everything I have that's 16+).
Attachment #713149 - Flags: review?(wjohnston) → review+
Comment on attachment 713149 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Old code with a check for 16.
User impact if declined: Thumbnails will be cut off.
Testing completed (on m-c, etc.): Landed on m-i just now.
Risk to taking this patch (and alternatives if risky): None. The "else" part works everywhere else and been tested a lot. Now we are making it the default.
String or UUID changes made by this patch: None.
Attachment #713149 - Flags: approval-mozilla-beta?
Attachment #713149 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/edea345c7c6b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Comment on attachment 713149 [details] [diff] [review]
Patch

We're not taking any new changes on beta at this point since we're about to release and this is not a release-blocking issue so only approving for Aurora.
Attachment #713149 - Flags: approval-mozilla-beta?
Attachment #713149 - Flags: approval-mozilla-beta-
Attachment #713149 - Flags: approval-mozilla-aurora?
Attachment #713149 - Flags: approval-mozilla-aurora+
Quite a visible known-issue on tablets; rel-note for 19?
Status: RESOLVED → VERIFIED
^
Flags: needinfo?(bbajaj)
Flags: needinfo?(bbajaj)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.