824483 - [Tablet] - Regression: about:home thumbnails are cut off; missing promo banner in landscape orientation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (12/24) - Screenshot

See screenshot

---
Nightly (12/24)
Asus Transformer Prime TF201 (Android 4.0.4)

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Nightly (12/24) - Screenshot (Portrait)

Portrait is fine; landscape issue.

Comment 2

[Wesley Johnston (:wesj)]

Hmm.. I can't repro this on my Galaxy Tab 10.1. Are you doing anything fancy? Starting in portrait then switching to landscape, or vice versa?

Comment 3

[Catalin Suciu [:csuciu]]

I cannot reproduce on Asus Transformer EEE (Android 4.0.4) using Nightly 20.0a1 (2013-01-07)

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: screenshot on Xoom with tab sidebar

I can reproduce this intermittently on my Motorola Xoom Wi-Fi (Android 4.1).  I also frequently get a layout like this attachment, where the marketplace promo banner is weirdly squashed.  This variant happens only when the tab sidebar is visible.  Or sometimes the tabs are not cut off (or barely cut off) but the marketplace banner is completely gone.

As far as I can tell, Firefox 18 Beta is not affected, but Firefox 19 Aurora is.

Comment 6

[Aaron Train [:aaronmt]]

Brad ran into this too in the dupe above.

Comment 7

[Aaron Train [:aaronmt]]

STR:

Rotate from portait to landscape

Comment 9

[Aaron Train [:aaronmt]]

This is now

Comment 10

[Aaron Train [:aaronmt]]

(too late for 19 I think)

Comment 11

[Aaron Train [:aaronmt]]

Steps for the TF201

i) Open Fennec in landscape

Comment 12

[Sriram Ramasubramanian [:sriram]]

Is there a regression range?

Comment 13

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

There's a condition to try and return the attribute "columnWidth" 's value if its running a version above 16. However, no attribute is specified in XML. Hence the value will be 0dp, this will cause the height to be shrunk while calculating the heightMeasureSpec.

Comment 14

[Wesley Johnston (:wesj)]

Comment on attachment 713149 [details] [diff] [review]
Patch

Review of attachment 713149 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/AboutHomeContent.java
@@ +789,5 @@
>              return getColumnWidth(getWidth());
>          }
>  
>          public int getColumnWidth(int width) {
> +            return (width - getPaddingLeft() - getPaddingRight()) / mNumberOfCols;

Cool. Can you add a note that super.getColumnWidth() doesn't always return the correct thing on all devices (because it seems to work on everything I have that's 16+).

Comment 15

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/edea345c7c6b

Comment 16

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 713149 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Old code with a check for 16.
User impact if declined: Thumbnails will be cut off.
Testing completed (on m-c, etc.): Landed on m-i just now.
Risk to taking this patch (and alternatives if risky): None. The "else" part works everywhere else and been tested a lot. Now we are making it the default.
String or UUID changes made by this patch: None.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/edea345c7c6b

Comment 18

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 713149 [details] [diff] [review]
Patch

We're not taking any new changes on beta at this point since we're about to release and this is not a release-blocking issue so only approving for Aurora.

Comment 19

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/53a7311047ef

Comment 20

[Aaron Train [:aaronmt]]

Quite a visible known-issue on tablets; rel-note for 19?

Comment 21

[Aaron Train [:aaronmt]]

^