824487 - Transition event callbacks sometimes don't fire

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Victor Porof [:vporof][:vp]]

This makes the following transitions instant and ugly:
* left and right panes translations
* global search results match bounces
* changed variables and properties flashes

Comment 1

[Girish Sharma [:Optimizer]]

If I am not wrong, this is a regression due to Bug 731974 and has been fixed by bug 823091 and will be fixed in tomorrow's nightly.

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1

If you're adding event listeners after setting an attribute which toggles transitions, you're gonna have a bad time.

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 695500 [details] [diff] [review]
v1

Review of attachment 695500 [details] [diff] [review]:
-----------------------------------------------------------------

just a comment nit. Fine otherwise.

::: browser/devtools/debugger/debugger-view.js
@@ +409,4 @@
>        return;
>      }
>  
> +    // Computes and sets the panes margins in order to hide or shown them.

s/shown/show/

Comment 4

[Paul Rouget [:paul]]

I can't apply this patch:

> unable to find 'browser/devtools/shared/widgets/VariablesView.jsm' for patching

Comment 5

[Victor Porof [:vporof][:vp]]

(In reply to Paul Rouget [:paul] from comment #4)
> I can't apply this patch:
> 
> > unable to find 'browser/devtools/shared/widgets/VariablesView.jsm' for patching

I'll rebase and land.

Comment 6

[Victor Porof [:vporof][:vp]]

Attachment: v1 rebased

rebased

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/2593683be851

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/2593683be851