824602 - Remove getUserData() usage from devtools

Status: RESOLVED FIXED

(DevTools :: General, defect)

Comment 1

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: work in progress

Remove get/setUserData() from browser/devtools.

But I have not considered about whether this change has any leak pattern or not. Then I attach the patch as "work in progress".

Comment 2

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: wip v2

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Movement seems to have stalled here. I believe this is now the only thing keeping us from removing userdata support.

Comment 4

[Joe Walker [:jwalker]]

CC harth who will probably be shortly landing significant changes to the style editor, and we'll need to port these changes to the new version

https://github.com/harthur/devtools-window/blob/remote-styleeditor/browser/devtools/styleeditor/StyleEditor.jsm

Comment 5

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

get/setUserData() are used in these points: http://mxr.mozilla.org/mozilla-central/search?string=%28get|set%29UserData&regexp=1&find=%2F*%2Fdevtools%2F*&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment 6

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to Joe Walker [:jwalker] from comment #4)
> CC harth who will probably be shortly landing significant changes to the
> style editor, and we'll need to port these changes to the new version
> 
> https://github.com/harthur/devtools-window/blob/remote-styleeditor/browser/
> devtools/styleeditor/StyleEditor.jsm

When will we land the new style editor to mozilla-central?
If we have some times before land it, I'll make a pull request for its github repository.

Comment 7

[Masatoshi Kimura [:emk]]

The style editor does no longer seem to use userData, but the split view still does.

Comment 8

[Brandon Benvie [:benvie]]

Attachment: SplitView remove getUserData usage

Replaces [gs]etUserData in SplitView with WeakMap usage.

Comment 9

[Brandon Benvie [:benvie]]

https://tbpl.mozilla.org/?tree=Try&rev=6b7f6d95e93b

Comment 10

[Brandon Benvie [:benvie]]

StyleEditorUtil.js has the following line:

> forEach(aDescriptor.userData, element.setUserData);

But nowhere is getUserData used in the style editor, so I think this is vestigial and can be removed?

Comment 11

[Brandon Benvie [:benvie]]

Attachment: Remove [sg]etUserData usage from devtools

https://tbpl.mozilla.org/?tree=Try&rev=69a24d7ba345

Comment 12

[Anton Kovalyov (:anton)]

https://hg.mozilla.org/integration/fx-team/rev/03f322ae358f

Comment 13

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/03f322ae358f