824621 - [FTU] 'Email address' placeholder for newsletter sign-up is not localized, stays English

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

B2G central emulator for Desktop (Windows XP) 20121224

In the FTU where you can sign up for information and events from Mozilla, the placeholder for the email address ('Email address') has not been localized.

Comment 2

[Axel Hecht [:Pike]]

Requesting blocking-basecamp, as this degrades our ftu experience in Portugese and Spanish.

The string itself is localized, so my assumption is that we don't retranslate it when the ftu switches locale.

Comment 3

[Kevin Grandon :kgrandon]

Actually I believe support is already there for this, we just need to localize the "emailAddress.placeholder" key in FTU.

Who can we assign this to for localization of that key? The git stuff is pretty straightforward, so I can open up a PR for that if desired. I'm not sure of the workflow for the localization HG stuff though.

Comment 4

[Axel Hecht [:Pike]]

Kevin, thanks for the hint, I'm having a patch now that'll communicate itself out to the l10n systems, too. PR coming up.

Comment 5

[Axel Hecht [:Pike]]

Attachment: use the right ID to match the placeholder attribute

Kevin, are you a good reviewer for this?

Comment 6

[Kevin Grandon :kgrandon]

Axel - That is the fix that's needed - but how does it work? Will this new key be propagated to other locales? Is there some manual changes we need to make?

I guess I just don't know the process regarding localization and gaia vs HG.

I have a branch as well: https://github.com/KevinGrandon/gaia/commit/4f7777e2f1bd8e215afd0f5d44d822ec2e3495ad This fixes the issue for the locales inside of gaia.

Comment 7

[Axel Hecht [:Pike]]

The process will work like this:
I or stas will take the change the change and port it to http://hg.mozilla.org/gaia-l10n/en-US/, at which point the l10n dashboard on https://l10n.mozilla.org/shipping/dashboard?tree=gaia will change the status, and report emailAddress as an obsolete entry, and emailAdress.placeholder as missing.

I'll likely do the actual porting, and will post in .l10n about why we had to rename the key.

Then the l10n teams have all they need to follow up.

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 697998 [details]
use the right ID to match the placeholder attribute

Cool, thanks for the info. In that case this change should be fine and work once it's propagated/translated for all of the locales.

Comment 9

[Axel Hecht [:Pike]]

I can't merge myself, can you?

Comment 10

[Kevin Grandon :kgrandon]

Landed https://github.com/mozilla-b2g/gaia/commit/3012db3404c13ebc4bba6f0adb500b3aafd88175

Comment 11

[Axel Hecht [:Pike]]

Thanks, I've also migrated the change to gaia-l10n/en-US, and posted to .l10n.

Comment 12

[Rebecca Billings [:rbillings]]

On the 1/12/13 unagi build, Portuguese still displays "Email address" in the newsletter field.

Comment 13

[Jason Smith [:jsmith]]

(In reply to Rebecca Billings from comment #12)
> On the 1/12/13 unagi build, Portuguese still displays "Email address" in the
> newsletter field.

Please file a new bug for the issue you encountered and link it as a dependency on this bug. Reopening makes tracking blockers a royal pain, so I'd suggest filing followups and linking appropriately.