824714 - wrong l10n IDs in the Dialer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[Fabien Cazenave [:kaze]]

Attachment: l10n fix

Regression caused by bug 817988:
https://github.com/mozilla-b2g/gaia/commit/60aac2d#diff-3

Here’s a quick fix.

Comment 1

[Fabien Cazenave [:kaze]]

Requesting BB+ status: l10n + follow-up of a BB+ bug.

Comment 2

[Etienne Segonzac (:etienne)]

What's the regression? (excepts introducing late-l10n keys)

If we can't have the strings I'd rather have no l10n-ids for those buttons than false ones...

Comment 3

[Fabien Cazenave [:kaze]]

Étienne, the regression is that two data-l10n-id have changed for no reason…

Comment 4

[Etienne Segonzac (:etienne)]

(In reply to Fabien Cazenave [:kaze] from comment #3)
> Étienne, the regression is that two data-l10n-id have changed for no reason…

I'm sorry something as lame as
|camera-a11y-button.aria-label=Hang Up|
got merged in the first place.

But let's not build on top of this mess and correct the keys.

Comment 5

[Fabien Cazenave [:kaze]]

Attachment: l10n fix

OK, then it’s a late-l10n fix.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 695763 [details] [diff] [review]
l10n fix

A lot of new strings is coming for e.me. Let's land that too.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/f467c57b2fd7b68de56b343a49432c858800ef6d