824734 - Don't allow the developer to edit their app name for packaged apps

Status: RESOLVED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P3)

Description

[Rob Hudson [:robhudson]]

Firefox OS does a validation check to make sure the name in the package manifest matches the name in the mini-manifest. If they don't match FxOS throws an error and refuses to install the app. For this reason, we need to make the package manifest's name be the sole source of truth.

This does raise some other questions and other work to be done:

* If the developer uploads a new version with a different name in the package manifest, we would need to update the app name in our database so it matches when we display the app on search pages, etc. (But only at reviewer approval time)

* If the developer deletes a version and the prior version has a different app name in the package manifest, update the db name.

* Blocklisting will also need to assume the app name so these match.

Comment 1

[Rob Hudson [:robhudson]]

I made some progress on this but got distracted by other bugs and didn't finish the last bit.

Work in progress branch:
https://github.com/robhudson/zamboni/tree/824734-cannot-edit-name

Comment 2

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/fbdba00 
https://github.com/mozilla/zamboni/commit/654ece7

Comment 3

[Rob Hudson [:robhudson]]

FYI: bug 828738 will open up name edits via updates in the manifest.