824743 - Wrong stylesheet check while opening the respective editor.

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect)

Description

[Girish Sharma [:Optimizer]]

First of all, due to this bug, opening of style editor from inspector or web console or any other code using gDevTools api is broken for every first time style editor is loaded and the required sheet is not the first one.

secondly, this also create intermittent on the test related to the opening of css error links in style editor from web console, for which the test is currently disabled (ref bug 808264)

So here foes the bug:

when style editor is loaded for the first time, it internally calls the selectStyleSheet with null params to load the first style sheet and just after that when some external code calls that method again, with soem proper styleSheet, the _styleSheetToSelect gets updated and we expect that the latest calues from that will be loaded.

But in the addChromeListener's onEditorLoad, we bail out of the very first added editor everytime, as it is obvious that the first stylesheet will be selected just after the style editor's load.

STR :
1) be on any page with at least 2 style sheets
2) Right click and inspect any node that has style applied to it from more than one of those style sheets.
3) Click the link to any stylesheet that is not the first stylesheet in the style editor (but do not load the style editor yet, retry if required) from teh sidebar.
4) Viola, aleays the first stylesheet would be selected.
5) without closing the toolbox, repeat the steps, proper stylesheet is selected.

Comment 1

[Girish Sharma [:Optimizer]]

Attachment: fix.

This or was always returning true for the first load of style editor.

Comment 2

[Girish Sharma [:Optimizer]]

try is green : https://tbpl.mozilla.org/?tree=Try&rev=cbed78f2e6b4

Comment 3

[Mihai Sucan [:msucan]]

Comment on attachment 695781 [details] [diff] [review]
fix.

Thank you for the bug report and for the fix. Really good catch! I'm hopeful that this is going to fix the intermittent test failure.

Landed:
https://hg.mozilla.org/integration/fx-team/rev/a3ebea25ef79

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/a3ebea25ef79