824825 - Need toolbar button and popup notification icons for tabs with camera / microphone access

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Dão Gottwald [:dao]]

see attachment 692404 [details]

As for the popup notification: it needs a 16*16px icon for the anchor and a 64*64px icon for the inside of the popup.

Comment 1

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Temporary icons: 16x16 microphone toolbar OSX and Windows, 64x64 OSX microphone and webcam

Just in case Shorlander's on PTO and it would be useful to have something sooner for testing, I'm attaching some temporary icons: OSX and Windows 16x16 webcam icons for toolbar, and 64x64 OSX webcam and microphone icons that could probably be used temporarily on any platform

Comment 2

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Temporary icons: 16x16 webcam toolbar icons OSX and Windows, 64x64 OSX microphone and webcam

Just in case Shorlander's on PTO and it would be useful to have something sooner for testing, I'm attaching some temporary icons: OSX and Windows 16x16 webcam icons for toolbar, and 64x64 OSX webcam and microphone icons that could probably be used temporarily on any platform

Comment 3

[Stephen Horlander [:shorlander]]

Attachment: Media Toolbar Icon - OSX

(In reply to Jennifer Morrow [:Boriss] (Firefox UX) from comment #2)
> Just in case Shorlander's on PTO and it would be useful to have something
> sooner for testing, I'm attaching some temporary icons: OSX and Windows
> 16x16 webcam icons for toolbar, and 64x64 OSX webcam and microphone icons
> that could probably be used temporarily on any platform

Thanks! I am back. I have toolbar icons and updated the icons on bug 798336. Bug 798336 Comment 23 indicates we only need one icon for camera and microphone. But I still have the individual Camera and Microphone icons that I marked as obsolete if we need them.

Comment 4

[Stephen Horlander [:shorlander]]

Attachment: Media Toolbar Icon - OSX - Lion

Comment 5

[Stephen Horlander [:shorlander]]

Attachment: Media Toolbar Icon - OSX - Lion@2x

Comment 6

[Stephen Horlander [:shorlander]]

Attachment: Media Toolbar Icon - Windows

Comment 7

[Stephen Horlander [:shorlander]]

Attachment: Media Toolbar Icon - Linux

Comment 8

[Stephen Horlander [:shorlander]]

Attachment: Media Toolbar Icon - Linux - Small

Comment 10

[Dão Gottwald [:dao]]

Stephen, can we also get the popup notification anchor icon as shown in attachment 692404 [details]? The icon indicating access is supposed to be different from the icon for access requests.

Comment 11

[Dão Gottwald [:dao]]

What's also missing is the toolbar icon with inverted colors for Windows.

Comment 12

[Stephen Horlander [:shorlander]]

(In reply to Dão Gottwald [:dao] from comment #11)
> What's also missing is the toolbar icon with inverted colors for Windows.

Oh right, I missed that. Thanks :)

I will attach the inverted icon and the access granted icon.

Comment 13

[Stephen Horlander [:shorlander]]

Attachment: Media Toolbar Icon - Windows

Updated dimensions to match the rest of the toolbar buttons.

Comment 14

[Stephen Horlander [:shorlander]]

Attachment: Media Toolbar Icon - Windows - Inverted

Comment 15

[Stephen Horlander [:shorlander]]

Attachment: Media Request Access Granted Icon

Comment 16

[Stephen Horlander [:shorlander]]

Attachment: Media Request Access Granted Icon @2x

Comment 17

[Stephen Horlander [:shorlander]]

Attachment: Media Toolbar Icon - OSX

Updated dimensions to match the rest of the toolbar buttons.

Comment 18

[Stephen Horlander [:shorlander]]

Attachment: Media Toolbar Icon - OSX - Lion

Updated dimensions to match the rest of the toolbar buttons.

Comment 19

[Stephen Horlander [:shorlander]]

Attachment: Media Toolbar Icon - OSX - Lion@2x

Updated dimensions to match the rest of the toolbar buttons.

Comment 20

[Dão Gottwald [:dao]]

Attachment: patch

Comment 21

[Dão Gottwald [:dao]]

Comment on attachment 701115 [details] [diff] [review]
patch

note on the excessive browser/themes/winstripe/browser.css changes: I removed the comments as they usually just annotate a single rule and aren't useful (and I didn't want to add a similar comment for the new icon), and moved the special tab view stuff after all the image regions for buttons using Toolbar.png.

Comment 22

[Justin Dolske [:Dolske]]

Comment on attachment 701115 [details] [diff] [review]
patch

Yeah, those comments were not very useful, good to seem them go.

You might consider the landing the move-and-decomment as a separate change set, so so that the actual changes for this bug are clear. But it's ok either way.

Comment 23

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5793475efa35

Comment 24

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5793475efa35

Comment 25

[Dão Gottwald [:dao]]

Comment on attachment 701115 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): getUserMedia feature
User impact if declined: inappropriate placeholder icon in the toolbar when sharing a camera or microphone with web content
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: n/a

Comment 26

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1fff5df1ac6a

Comment 27

[Jason Smith [:jsmith]]

Verified through some exploratory testing on desktop on Windows 7, OS X 10.7, and Ubuntu 12 with the gum test page and my test pc app with single vs. multiple tabs + concurrent use. As of today's build, there was one followup that Dao already knows about - the share notification is always indicating the last set of devices shared on the last gum call, not the union.