Closed
Bug 824886
Opened 13 years ago
Closed 13 years ago
Remove dead ThreadPoolWorker::threadPool_ field.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.81 KB,
patch
|
nmatsakis
:
review+
|
Details | Diff | Splinter Review |
clang 3.2 warns:
js/src/vm/ThreadPool.cpp:32:23 [-Wunused-private-field] private field 'threadPool_' is not used
|
Assignee | |
Comment 1•13 years ago
|
||
This patch removes ThreadPoolWorker::threadPool_ because it's unused.
Attachment #695908 -
Flags: review?(wmccloskey)
|
|
Assignee | |
Updated•13 years ago
|
Blocks: buildwarning
Comment on attachment 695908 [details] [diff] [review]
Remove dead ThreadPoolWorker::threadPool_ field.
This looks fine to me, but Niko wrote the code. Maybe there are plans to use the field in the future?
Attachment #695908 -
Flags: review?(wmccloskey) → review?(nmatsakis)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 695908 [details] [diff] [review]
Remove dead ThreadPoolWorker::threadPool_ field.
This looks fine.
Attachment #695908 -
Flags: review+
|
|
Assignee | |
Updated•13 years ago
|
Attachment #695908 -
Flags: review?(nmatsakis)
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•