Closed
Bug 824891
Opened 13 years ago
Closed 12 years ago
Change |result| from XML_Error to XML_Status to quell some -Wenum-conversion warnings.
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.06 KB,
patch
|
jst
:
review+
peterv
:
review+
|
Details | Diff | Splinter Review |
clang 3.2. warns:
parser/expat/lib/xmlparse.c:1530:18 [-Wenum-conversion] implicit conversion from enumeration type 'enum XML_Status' to different enumeration type 'enum XML_Error'
parser/expat/lib/xmlparse.c:1548:18 [-Wenum-conversion] implicit conversion from enumeration type 'enum XML_Status' to different enumeration type 'enum XML_Error'
parser/expat/lib/xmlparse.c:1584:12 [-Wenum-conversion] implicit conversion from enumeration type 'enum XML_Error' to different enumeration type 'enum XML_Status'
|
Assignee | |
Comment 1•13 years ago
|
||
This patch changes |result| from XML_Error to XML_Result, which fixes the
warnings.
Attachment #695915 -
Flags: review?(jst)
|
|
Assignee | |
Updated•13 years ago
|
Blocks: buildwarning
|
||
Comment 2•13 years ago
|
||
Comment on attachment 695915 [details] [diff] [review]
Change |result| from XML_Error to XML_Status to quell some -Wenum-conversion warnings.
r=jst, but peterv should look this over too as he has done most of the work on this code...
Attachment #695915 -
Flags: review?(peterv)
Attachment #695915 -
Flags: review?(jst)
Attachment #695915 -
Flags: review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
peterv: review ping.
|
||
Updated•12 years ago
|
Attachment #695915 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•