824891 - Change |result| from XML_Error to XML_Status to quell some -Wenum-conversion warnings.

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Nicholas Nethercote [inactive]]

clang 3.2. warns:

  parser/expat/lib/xmlparse.c:1530:18 [-Wenum-conversion] implicit conversion from enumeration type 'enum XML_Status' to different enumeration type 'enum XML_Error'
  parser/expat/lib/xmlparse.c:1548:18 [-Wenum-conversion] implicit conversion from enumeration type 'enum XML_Status' to different enumeration type 'enum XML_Error'
  parser/expat/lib/xmlparse.c:1584:12 [-Wenum-conversion] implicit conversion from enumeration type 'enum XML_Error' to different enumeration type 'enum XML_Status'

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Change |result| from XML_Error to XML_Status to quell some -Wenum-conversion warnings.

This patch changes |result| from XML_Error to XML_Result, which fixes the
warnings.

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 695915 [details] [diff] [review]
Change |result| from XML_Error to XML_Status to quell some -Wenum-conversion warnings.

r=jst, but peterv should look this over too as he has done most of the work on this code...

Comment 3

[Nicholas Nethercote [inactive]]

peterv: review ping.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b338f7f9fcc

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/1b338f7f9fcc