Closed Bug 824891 Opened 7 years ago Closed 7 years ago

Change |result| from XML_Error to XML_Status to quell some -Wenum-conversion warnings.

Categories

(Core :: HTML: Parser, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: njn, Assigned: njn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

clang 3.2. warns:

  parser/expat/lib/xmlparse.c:1530:18 [-Wenum-conversion] implicit conversion from enumeration type 'enum XML_Status' to different enumeration type 'enum XML_Error'
  parser/expat/lib/xmlparse.c:1548:18 [-Wenum-conversion] implicit conversion from enumeration type 'enum XML_Status' to different enumeration type 'enum XML_Error'
  parser/expat/lib/xmlparse.c:1584:12 [-Wenum-conversion] implicit conversion from enumeration type 'enum XML_Error' to different enumeration type 'enum XML_Status'
This patch changes |result| from XML_Error to XML_Result, which fixes the
warnings.
Attachment #695915 - Flags: review?(jst)
Blocks: buildwarning
Comment on attachment 695915 [details] [diff] [review]
Change |result| from XML_Error to XML_Status to quell some -Wenum-conversion warnings.

r=jst, but peterv should look this over too as he has done most of the work on this code...
Attachment #695915 - Flags: review?(peterv)
Attachment #695915 - Flags: review?(jst)
Attachment #695915 - Flags: review+
peterv: review ping.
Attachment #695915 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/1b338f7f9fcc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.