Closed
Bug 824923
Opened 12 years ago
Closed 12 years ago
Stablize WebRTC mochitests against Javascript exceptions to prevent timeouts
Categories
(Core :: WebRTC, defect, P2)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [WebRTC][blocking-webrtc+][qa-])
Attachments
(1 file)
|
1.30 KB,
patch
|
jesup
:
review+
whimboo
:
checkin+
|
Details | Diff | Splinter Review |
We do not catch global JS exceptions within the WebRTC mochitests so far. That causes an early abort without the call of 'SimpleTest.finish()'. That means the test harness doesn't detect that the test has actually been finished. After 330s we kill the browser.
That should not happen and we have to improve our code by catching those global exceptions and to react accordingly.
The upcoming patch here will unhide the problem seen by bug 823056.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #695988 -
Flags: review?(rjesup)
|
||
Updated•12 years ago
|
Priority: -- → P2
Whiteboard: [WebRTC][automation-blocked][blocking-webrtc+]
|
||
Updated•12 years ago
|
Attachment #695988 -
Flags: review?(rjesup) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 695988 [details] [diff] [review]
Patch v1
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0d93141fe0c
Attachment #695988 -
Flags: checkin+
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
|
||
Updated•12 years ago
|
Flags: in-testsuite+
Whiteboard: [WebRTC][automation-blocked][blocking-webrtc+] → [WebRTC][automation-blocked][blocking-webrtc+][qa-]
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [WebRTC][automation-blocked][blocking-webrtc+][qa-] → [WebRTC][blocking-webrtc+][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•