Last Comment Bug 824955 - WebRTC crash [@nr_ice_candidate_pair_create]
: WebRTC crash [@nr_ice_candidate_pair_create]
Status: RESOLVED FIXED
[WebRTC], [blocking-webrtc+], [qa-]
: crash
Product: Core
Classification: Components
Component: WebRTC: Networking (show other bugs)
: Trunk
: x86_64 Mac OS X
: P1 critical (vote)
: mozilla20
Assigned To: Jan-Ivar Bruaroey [:jib]
: Jason Smith [:jsmith]
:
Mentors:
Depends on:
Blocks: 792125
  Show dependency treegraph
 
Reported: 2012-12-27 06:36 PST by Christoph Diehl [:posidron]
Modified: 2013-01-26 07:08 PST (History)
8 users (show)
jsmith: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
callstack (5.00 KB, text/plain)
2012-12-27 06:36 PST, Christoph Diehl [:posidron]
no flags Details
SDP (1.05 KB, text/plain)
2012-12-27 06:36 PST, Christoph Diehl [:posidron]
no flags Details
Candidate Username/pwd nullcheck (1.38 KB, patch)
2013-01-04 09:37 PST, Jan-Ivar Bruaroey [:jib]
rjesup: review+
rjesup: checkin+
Details | Diff | Splinter Review

Description Christoph Diehl [:posidron] 2012-12-27 06:36:06 PST
Created attachment 696030 [details]
callstack

It happened while trying to fuzz the SDP.

./media/mtransport/third_party/nICEr/src/ice/ice_candidate_pair.c:128
    if(r=r_data_make(&pair->stun_client->params.ice_binding_request.password,(UCHAR *)rpwd,strlen(rpwd)))
      ABORT(r);


Tested with m-c changeset: 117036:f5ed2691d901
Comment 1 Christoph Diehl [:posidron] 2012-12-27 06:36:40 PST
Created attachment 696031 [details]
SDP
Comment 2 Jan-Ivar Bruaroey [:jib] 2013-01-04 09:37:29 PST
Created attachment 697962 [details] [diff] [review]
Candidate Username/pwd nullcheck
Comment 4 Ed Morley [:emorley] 2013-01-07 08:24:54 PST
https://hg.mozilla.org/mozilla-central/rev/965e97b75bfa

Note You need to log in before you can comment on or make changes to this bug.