Closed Bug 824958 Opened 7 years ago Closed 7 years ago

Eliminate pointless nsXULPrototypeScript::ScriptObjectHolder structure

Categories

(Core :: XUL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

There's no purpose to this wrapper structure any more.

In addition, I made the script field private and added a getter method. It needs to be rooted/unrooted when it is changed, so people shouldn't be poking around in it randomly.

try run: https://tbpl.mozilla.org/?tree=Try&rev=56e8973bc627

(Spun off from bug 785493.)
Comment on attachment 696033 [details] [diff] [review]
remove structure and add getter method

Try run looked good.

This doesn't really block the other bug, but it would be nice to have.
Attachment #696033 - Flags: review?(bugs)
Attachment #696033 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/75a09d9557b9
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.