Closed
Bug 824958
Opened 12 years ago
Closed 12 years ago
Eliminate pointless nsXULPrototypeScript::ScriptObjectHolder structure
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(1 file)
|
14.12 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
There's no purpose to this wrapper structure any more.
In addition, I made the script field private and added a getter method. It needs to be rooted/unrooted when it is changed, so people shouldn't be poking around in it randomly.
try run: https://tbpl.mozilla.org/?tree=Try&rev=56e8973bc627
(Spun off from bug 785493.)
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 696033 [details] [diff] [review]
remove structure and add getter method
Try run looked good.
This doesn't really block the other bug, but it would be nice to have.
Attachment #696033 -
Flags: review?(bugs)
|
||
Comment 3•12 years ago
|
||
\o/
|
||
Updated•12 years ago
|
Attachment #696033 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•