Closed Bug 824970 Opened 12 years ago Closed 12 years ago

convert nsIDOMRect to webidl

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla20

People

(Reporter: tbsaunde, Assigned: tbsaunde)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-needed)

Attachments

(7 files)

nsDOMCSSRect should use nsROCSSPrimitiveValue 12 years ago Trevor Saunders (:tbsaunde) 2.64 KB, patch	bzbarsky : review+	Details \| Diff \| Splinter Review
wrapper cache and cycle collect nsDOMCSSRect 12 years ago Trevor Saunders (:tbsaunde) 2.34 KB, patch	bzbarsky : review+	Details \| Diff \| Splinter Review
store nsDOMCSSRect* in nsROCSSPrimitiveValue 12 years ago Trevor Saunders (:tbsaunde) 2.83 KB, patch	bzbarsky : review+	Details \| Diff \| Splinter Review
add Rect webidl 12 years ago Trevor Saunders (:tbsaunde) 737 bytes, patch	bzbarsky : review+	Details \| Diff \| Splinter Review
webidl api for Rect 12 years ago Trevor Saunders (:tbsaunde) 925 bytes, patch	bzbarsky : review+	Details \| Diff \| Splinter Review
use webidl for Rect 12 years ago Trevor Saunders (:tbsaunde) 7.99 KB, patch	bzbarsky : review+	Details \| Diff \| Splinter Review
nsROCSSPrimitiveValue::GetRectValue() should return nsDOMCSSRect* 12 years ago Trevor Saunders (:tbsaunde) 2.80 KB, patch	bzbarsky : review+	Details \| Diff \| Splinter Review

Trevor Saunders (:tbsaunde)

Assignee

Description

•

12 years ago

      No description provided.

Trevor Saunders (:tbsaunde)

Assignee

Comment 1

•

12 years ago

Attached patch nsDOMCSSRect should use nsROCSSPrimitiveValue — Details — Splinter Review

Attachment #696082 - Flags: review?(bzbarsky)

Trevor Saunders (:tbsaunde)

Assignee

Comment 2

•

12 years ago

Attached patch wrapper cache and cycle collect nsDOMCSSRect — Details — Splinter Review

Attachment #696084 - Flags: review?(bzbarsky)

Trevor Saunders (:tbsaunde)

Assignee

Comment 3

•

12 years ago

Attached patch store nsDOMCSSRect* in nsROCSSPrimitiveValue — Details — Splinter Review

Attachment #696086 - Flags: review?(bzbarsky)

Trevor Saunders (:tbsaunde)

Assignee

Comment 4

•

12 years ago

Attached patch add Rect webidl — Details — Splinter Review

Attachment #696087 - Flags: review?(bzbarsky)

Trevor Saunders (:tbsaunde)

Assignee

Comment 5

•

12 years ago

Attached patch webidl api for Rect — Details — Splinter Review

Attachment #696088 - Flags: review?(bzbarsky)

Trevor Saunders (:tbsaunde)

Assignee

Comment 6

•

12 years ago

Attached patch use webidl for Rect — Details — Splinter Review

Attachment #696089 - Flags: review?(bzbarsky)

Trevor Saunders (:tbsaunde)

Assignee

Comment 7

•

12 years ago

Attached patch nsROCSSPrimitiveValue::GetRectValue() should return nsDOMCSSRect* — Details — Splinter Review

Attachment #696090 - Flags: review?(bzbarsky)

Boris Zbarsky [:bzbarsky]

Comment 8

•

12 years ago

Comment on attachment 696082 [details] [diff] [review]
nsDOMCSSRect should use nsROCSSPrimitiveValue

r=me

Attachment #696082 - Flags: review?(bzbarsky) → review+

Boris Zbarsky [:bzbarsky]

Comment 9

•

12 years ago

Comment on attachment 696084 [details] [diff] [review]
wrapper cache and cycle collect nsDOMCSSRect

r=me

Attachment #696084 - Flags: review?(bzbarsky) → review+

Boris Zbarsky [:bzbarsky]

Comment 10

•

12 years ago

Comment on attachment 696086 [details] [diff] [review]
store nsDOMCSSRect* in nsROCSSPrimitiveValue

r=me

Attachment #696086 - Flags: review?(bzbarsky) → review+

Boris Zbarsky [:bzbarsky]

Comment 11

•

12 years ago

Comment on attachment 696087 [details] [diff] [review]
add Rect webidl

r=me

Attachment #696087 - Flags: review?(bzbarsky) → review+

Boris Zbarsky [:bzbarsky]

Comment 12

•

12 years ago

Comment on attachment 696088 [details] [diff] [review]
webidl api for Rect

r=me

Attachment #696088 - Flags: review?(bzbarsky) → review+

Boris Zbarsky [:bzbarsky]

Comment 13

•

12 years ago

Comment on attachment 696089 [details] [diff] [review]
use webidl for Rect

You need to SetIsDOMBinding() in the nsDOMCSSRect constructor.  r=me with that.

Attachment #696089 - Flags: review?(bzbarsky) → review+

Boris Zbarsky [:bzbarsky]

Comment 14

•

12 years ago

Comment on attachment 696090 [details] [diff] [review]
nsROCSSPrimitiveValue::GetRectValue() should return nsDOMCSSRect*

r=me

Attachment #696090 - Flags: review?(bzbarsky) → review+

Trevor Saunders (:tbsaunde)

Assignee

Comment 15

•

12 years ago

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/0534210e43e5
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/516b3defe68d
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/41f218bd3082
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/355d2e8ede64
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/03ece6d48d9f
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/280420584744

Tom S [:evilpie]

Updated

•

12 years ago

Blocks: ParisBindings

(no longer active)

Comment 16

•

12 years ago

https://hg.mozilla.org/mozilla-central/rev/0534210e43e5
https://hg.mozilla.org/mozilla-central/rev/516b3defe68d
https://hg.mozilla.org/mozilla-central/rev/41f218bd3082
https://hg.mozilla.org/mozilla-central/rev/355d2e8ede64
https://hg.mozilla.org/mozilla-central/rev/03ece6d48d9f
https://hg.mozilla.org/mozilla-central/rev/280420584744
https://hg.mozilla.org/mozilla-central/rev/cdc397a8e017

Status: NEW → RESOLVED

Closed: 12 years ago

Resolution: --- → FIXED

Target Milestone: --- → mozilla20

Jean-Yves Perrier [:teoli]

Updated

•

9 years ago

Keywords: dev-doc-needed

Nobody; OK to take it and work on it

Updated

•

5 years ago

Component: DOM → DOM: Core & HTML

You need to log in before you can comment on or make changes to this bug.