825002 - We should not start compositor thread if it is already started.

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Oleg Romashin (:romaxa)]

In OMTC embedding I do created compositor loop using StartUpWithExistingThread
And later one more compositor thread is created 
https://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxPlatform.cpp#294
And there is no check for existing compositor thread.
I use pref or MOZ_USE_OMTC in order to trigger useOffMainThreadCompositing = true and run ImageBridgeChild::StartUp.. but together with that it is starting CompositorThread which I don't need.
so I guess it make sense to check for existing thread using CompositorParent::CompositorLoop() API.

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Check for compositor loop before calling StartUp

Comment 2

[Nicolas Silva [:nical]]

Comment on attachment 696064 [details] [diff] [review]
Check for compositor loop before calling StartUp

Review of attachment 696064 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Just one remark, not critically important but I'd rather have this checked in CompositorParent::Startup and CompositorParent::StartupWithExistingThread like ImageBridge does. Because when looking at this code the first reflex is to think that this case is handled for CompositorParent and not for ImageBridge. Or check for ImageBridgeChild::IsCreated in gfxPlatform.cpp instead of StartupWithExistingThread if you prefer.

Comment 3

[Oleg Romashin (:romaxa)]

Attachment: Check if compositor thread already started

Comment 4

[Nicolas Silva [:nical]]

Comment on attachment 696525 [details] [diff] [review]
Check if compositor thread already started

Review of attachment 696525 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

Comment 5

[Oleg Romashin (:romaxa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2113a30dfcc

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a2113a30dfcc