825060 - Enable the new Downloads View by default when the panel is enabled

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P1)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

It's time to get rid of browser.library.useNewDownloadsView and collect bug reports from Nightly testing.

Theming got a first pass on all platforms, and we are actively working on performances in Bug 822343.
Some brief lag in showing the view is expected until Bug 822343 is properly resolved, but enabling it we can begin collecting feedback on its functionality, not just on performances.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.0

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 696125 [details] [diff] [review]
patch v1.0

Looks good to me - thanks Marco!

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5840a8b5cc21

Comment 4

[Josh Matthews [:jdm]]

Backed out for failing browser_library_downloads.js: https://hg.mozilla.org/integration/mozilla-inbound/rev/91c3020669f0

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.1

Fix the test, and a couple trivial warnings.

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

relanded with fixed test, thanks for the backout.
https://hg.mozilla.org/integration/mozilla-inbound/rev/77f4c8155c60

Comment 7

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/77f4c8155c60

Comment 8

[Jim Jeffery not reading bug-mail 1/2/11]

Probably not a big deal, but if a Nightly tester added the pref:

browser.library.useNewDownloadsView to test the Places Download Manager, that pref is not removed with this patch. 

Resetting the manually added pref and restarting the Nightly no longer shows the pref as noted above.

Comment 9

[Simona Badau, Desktop QA]

Verified as fixed on the latest Nightly - when the downloads panel is enabled the new downloads view (in the Library) is opened.

Verified on Windows 7, Ubuntu 12.10 and Mac OS X 10.8.2:
Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20130102 Firefox/20.0 Build ID: 20130102030907
Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20130103 Firefox/20.0 Build ID: 20130103030946
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20130103 Firefox/20.0 Build ID: 20130103030946