825089 - [Browser] Display sad face icon in tab list for crashed tabs

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P2)

Description

[mlevin]

Attachment: No Thumbnail view of error indicator

Unagi build ID 20121217070202

Steps:
1. In a Cygwin terminal session type the following: adb shell ps |grep container
2. launch browser 
3. In the terminal session type the following: adb shell kill -11 <pid of browser> ie adb shell kill -11 980 (note : it should be the last plugin-container process). (See ER1)
4. Long press on home button. (See ER2)

Expected:
ER1 - Verify that an error indicator shows up on the Unagi browser screen.
ER2 - verify that you see the thumbnail of the error indicator.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This is a known bug in the way window snapshots are made of the browser app.  It's not feasibly fixable in v1.

Comment 2

[mlevin]

This is Moztrap test case #1662.

Comment 3

[Ben Francis [:benfrancis]]

I think what this refers to is actually the visual design for the browser https://www.dropbox.com/sh/retlarkzknj7luc/QOq2Rv4aXt#f:Firefox_Browser_Crashed_Tabs_20130207.jpg

It suggests we should show a sad face icon in the tab list in place of the screenshot thumbnail. I think that should be fairly easy to implement.

Comment 4

[Dale Harvey (:daleharvey)]

Does anywhere know where the source assets for this are? (or can anyone give me the sad face icon at a proper res)

Comment 5

[Ian Barlow (:ibarlow)]

Adding Eric Pang, our graphics production expert. Eric, can you please post some assets for this "sad face tab"? See http://cl.ly/image/2j2D1d0w0B1W for reference

Thanks!

Comment 6

[Dale Harvey (:daleharvey)]

The dimensions for this are: width: 9rem; height: 6.5rem; btw

Comment 7

[Ian Barlow (:ibarlow)]

Attachment: crashed tab icons.zip

Graphic assets for crashed tabs (in low- and hi-res)

Comment 8

[Dale Harvey (:daleharvey)]

Attachment: Display sad face on crashed tabs

Comment 9

[Dale Harvey (:daleharvey)]

Ian, as the rest of the assets have both a 1.5x and 2x images, I downscaled the 2x one to produce a 1.5x version, just needinfoing to check thats ok.

Brad, this is another one I wouldnt mind a bit of help coming up with a clean test plan, should we be mocking the mozbrowser api here or actually killing a tab, and how do we want to test that actually results in the correct display

I would probably go for not mocking mozbrowser as its fairly large and complex, actually killing the process as long as we are able to seems easier, but not sure about testing the display

Comment 10

[Ian Barlow (:ibarlow)]

Attachment: crashed tab icons 2.zip

Thanks Dale, didn't realize there was a 1.5x size -- I'd rather us use a purpose-built graphic for that instead of scaling, a new set is attached here with the 1.5x size.

Comment 11

[Ben Francis [:benfrancis]]

Comment on attachment 779498 [details] [review]
Display sad face on crashed tabs

r+me

Comment 12

[Ben Francis [:benfrancis]]

(r+me with new assets)

Comment 13

[Dale Harvey (:daleharvey)]

Merged in: https://github.com/mozilla-b2g/gaia/commit/79bc7d8c75334d2a3bdf1fafb747ec01297ae732

Comment 14

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Dale Harvey (:daleharvey) from comment #9)
> Ian, as the rest of the assets have both a 1.5x and 2x images, I downscaled
> the 2x one to produce a 1.5x version, just needinfoing to check thats ok.
> 
> Brad, this is another one I wouldnt mind a bit of help coming up with a
> clean test plan, should we be mocking the mozbrowser api here or actually
> killing a tab, and how do we want to test that actually results in the
> correct display
> 
> I would probably go for not mocking mozbrowser as its fairly large and
> complex, actually killing the process as long as we are able to seems
> easier, but not sure about testing the display

I think I agree that it would be better to kill the process, which seems at the same time cleaner and tests more of the code.

In terms of testing, it seems like you could load a page that renders all red and then kill it. If you see no red in the display, the thumbnail has been replaced. bonus points for actually testing that the thumbnail matches the one we want.

Comment 15

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified: 
"mozilla-central" revision="2983ca6d4d1a"
"gecko.git" "9a1a3a0658790de7f95e0ab4a18ba78f71266b96"/>
"gaia.git" revision="5aac3408cdefed4afb1b14d57a69d713c69b46b9"
Build ID: 2013-07-24-03-02-03
MC/master build
Unagi

Currently if you tap the settings button, you will get the content crash thumbnail.
We'll need to find a better way to verify content crashes for later.

It seems at least in this build that if you kill -11 the tab content you can force a crash + a tab crash.

Comment 16

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Moztrap test cases created:

https://moztrap.mozilla.org/manage/case/9223/
https://moztrap.mozilla.org/manage/case/1662/

Comment 17

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

To note: there already are test cases in regards to reloading, closing the crashed tab.

Comment 18

[Dale Harvey (:daleharvey)]

This requires killing processes so probably best for you to sign off brad

There is a follow up in a seperate bug https://bugzilla.mozilla.org/show_bug.cgi?id=898112

Comment 19

[Brad Lassey [:blassey] (use needinfo?)]

accepted