Fix -Wint-to-pointer-cast warnings in nsTraceRefcntImpl.cpp.

RESOLVED FIXED in mozilla20

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

(Blocks: 1 bug)

unspecified
mozilla20
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

clang 3.2 emits two warnings due to casting int32_t values to void*:

  xpcom/base/nsTraceRefcntImpl.cpp:610:55 [-Wint-to-pointer-cast] cast to 'const void *' from smaller integer type 'int32_t' (aka 'int')
  xpcom/base/nsTraceRefcntImpl.cpp:818:42 [-Wint-to-pointer-cast] cast to 'const void *' from smaller integer type 'int32_t' (aka 'int')
Created attachment 696189 [details] [diff] [review]
Fix -Wint-to-pointer-cast warnings in nsTraceRefcntImpl.cpp.

This patch fixes this by using intptr_t instead of int32_t for serial
numbers.

bsmedberg, I wasn't sure if you were the right reviewer for this.  Please
change to the request to someone else if that's appropriate.
Attachment #696189 - Flags: review?(benjamin)

Updated

5 years ago
Attachment #696189 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/4436a72b4f2c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.