Closed Bug 825107 Opened 7 years ago Closed 7 years ago

Fix -Wint-to-pointer-cast warnings in nsTraceRefcntImpl.cpp.

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: njn, Assigned: njn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

clang 3.2 emits two warnings due to casting int32_t values to void*:

  xpcom/base/nsTraceRefcntImpl.cpp:610:55 [-Wint-to-pointer-cast] cast to 'const void *' from smaller integer type 'int32_t' (aka 'int')
  xpcom/base/nsTraceRefcntImpl.cpp:818:42 [-Wint-to-pointer-cast] cast to 'const void *' from smaller integer type 'int32_t' (aka 'int')
This patch fixes this by using intptr_t instead of int32_t for serial
numbers.

bsmedberg, I wasn't sure if you were the right reviewer for this.  Please
change to the request to someone else if that's appropriate.
Attachment #696189 - Flags: review?(benjamin)
Blocks: buildwarning
Attachment #696189 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/4436a72b4f2c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.